-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional devices #3
Comments
Hi Jan!
It's just great that you want to contribute and upgrade this plugin!
Since there is no API V2 documentation available all we need is to get all fields that API is delivering for the washer. You just need to generate wideq token file, debug the script and check what fields you will get from the API. With these we can modify the plugin to have washers support.
You can try by yourself or I can do it for you, but I will need your wideq token file (I don't have LG washer).
Was your washer detected by the plugin?
I'm pleased to help.
|
Hey, I'm fine with building the washer interface (it won't be the first plugin I'm building). And yes, it was returned as a V2 device. So my plan is to first explore the API for the washer a bit and then rework the example.py to get the generic part out to do the setup and separate the wrapper functionality for the AC in such a way that I can re-use it for the washer and perhaps later someone else can build the other types (it's not so convenient to do when you're not owning one). Give me a couple of days and I'll come up with a proposal. |
Hello, We also have an LG washer and intresed in the washer interface :) @JanJaapKo did you have any luck to get it to work? Thanks, Michael |
I haven't got any further than playing around a bit, since I've got another plugin I'm fixing first..... Will probably take me about a month or so to get some pilot version to work....... So I haven't forgotten about it ;) |
Hi all, we too are working with dryer & washer combination. I've found this repository by @fison67 that has a v1 and a v2 set of commands for multiple devices, supporting Korean and English languages. Have a look in the Groovy files for a dryer here https://github.com/fison67/LG-Connector/blob/master/devicetypes/fison67/lg-dryer.src/lg-dryer.groovy |
@JanJaapKo any luck or news to get it to work? :) Thanks |
Hi ! Cheers ! |
Hi all, I haven't had much time to spend on this one lately (busy with other plugins and other hobbies as well....) so haven't done anything, basically and do not really foresee to do so anytime soon...... What I saw from first investigation is that the design of the plugin needs to be reworked to accommodate the fact that it needs to handle multiple device types. Now it is simply handling one type (AC). If anyone else wants to have a go, be my guest ;). I'll be happy to help out. |
Currently it does not. The thing is that every type of device has to be added separately with parsing it's unique wideq file and API fields. It's easy when I own a device (AC) or somebody will send me his wideq file (like we did with heat pump), otherwise it's hard to implement something new. |
hello just downloaded your plugin (i have LG washer) i can send wideq_state.json or if you give me info where to dig i can try.... :) found this file with washer&Drier for HA https://github.com/ollo69/ha-smartthinq-sensors/blob/0b320c64206dae4750b7b04efd04014d35b449fd/custom_components/smartthinq_sensors/wideq/devices/washerDryer.py and here is my device.data output and here json model_info_url https://pastebin.com/rqpCLbdu |
Please edit your message to remove your ID as a safety measure. |
@devrosx thanks for sharing your response. The API documentation for LG can be found here. I've found the washer and dryer commands and readouts. The structure is essentially available and some communication client elements are already available actually. I will confirm that the already available washer and dryer files fit the current profiles. Then the plugin needs to be updated accordingly. Maybe @JanJaapKo or @TokTias want to join the effort? |
Hey @Artens I'll have a look the coming week into adding the washer. |
@Artens , @majki09 the plugin currently takes the users selection for the device type. I think it would be much more powerfull to query the API for the device type, do you agree? We can throw an error for none supported types. As future extension, we can then also control multiple devices from 1 instance of the plugin. |
Yes! This is good idea in my opinion. I like approaches like this. One instance, many device types. That should look really good. Technically it should be first checked in the API if we have any info about all devices/types available on user's account. Then the script would iterate through all of device types, adding appropriate domoticz instances. And if some device on account is not supported by our plugin it will throw a Warning into the logs. I think this would be the best approach. @JanJaapKo would you mind to create new issue for this (with enhancement label) as it is your idea? |
Well sure can do that. However, it would (perhaps) overlap with this ticket, since (as far as I can see now) the current implementation seems to be using a different version of the API. So that would require quite some refactoring firstly on the API and secondly on the plugin itself, as we'd need to move to the Domoticz extended framework (where 256 units can be connected per device). But I'll focus on getting the washer to work first...... |
Two topics are relevant if I understand everything correctly:
|
Still working on this topic but progressing slowly. This plugin is quite complex to my opinion, could do with some simplification...... |
hi there! |
Hi @majki09 ,
I've got an LG washer I'dd like to add using your plugin as basis. I could refactor the whole thing so this plugin supports more than just the AC's, but that would require some work on your end to keep the AC u pand running (I may break some things....)
So do you feel like doing this? If not, I'll just fork
The text was updated successfully, but these errors were encountered: