Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong path #46

Closed
jafc76 opened this issue Oct 30, 2022 · 13 comments
Closed

Wrong path #46

jafc76 opened this issue Oct 30, 2022 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@jafc76
Copy link

jafc76 commented Oct 30, 2022

What happened

After a clean Install on a Raspberry Pi of Klipper, Moonraker, Mainsail, KlipperScreen and Crowsnest I can see that the path of crowsnest.conf and crowsnest.log is wrong.

It should be:
/home/pi/printer_data/config for crowsnest.conf
/home/pi/printer_data/logs for crownsnest.log

It's installed here:
/home/pi/klipper_config for crowsnest.conf
/home/pi/klipper_logs for crownsnest.log

So I was changing the configuration of the camera but had no effect and nothing changed until I changed the same file on the old path.

What did you expect to happen

The path should be changed.

How to reproduce

After to update, everybody will have the same problem

Additional information

Thank you so much!

@jafc76 jafc76 added the bug Something isn't working label Oct 30, 2022
@KwadFan
Copy link
Member

KwadFan commented Nov 1, 2022

Hello,
Thank you for reporting! Yes, this is a known issue.

I would be happy if you could try this branch:
https://github.com/mainsail-crew/crowsnest/tree/ref/installer
I refactored the whole mechanism. Any thoughts and improvements on this are welcome.

This should also get rid of #41

Regards Kwad

@jafc76
Copy link
Author

jafc76 commented Nov 1, 2022

Thanks mate!!

@Guilouz
Copy link

Guilouz commented Nov 3, 2022

And in case of multi instances path must be /home/pi/printer_1_data/config

@KwadFan
Copy link
Member

KwadFan commented Nov 3, 2022

I have no multiinstance in mind here. But as you have to configure the installer for your desired paths its up to you.

Default paths are set for single instance.
Despite the fact it make not a real sense to me, till yet. because all cams should be connected to the same pi.
To be honest, I never had that in mind, but I dont know if it will run with different cfg and env files 🤷‍♂️

@tinymachines3d
Copy link

@KwadFan what about update manager entry for this other branch? When I change to primary branch: ref/installer, it breaks.

@KwadFan
Copy link
Member

KwadFan commented Nov 3, 2022

@KwadFan what about update manager entry for this other branch? When I change to primary branch: ref/installer, it breaks.

That branch is only thought for testing. As soon I merged that you can switch back to master branch

@tinymachines3d
Copy link

@KwadFan cloning the ref/installer branch works and is nicely setup. How much longer does it need tested?

@Guilouz
Copy link

Guilouz commented Nov 3, 2022

Confirmed tested too and it's working for multi instances too by typing the correct path.

@KwadFan
Copy link
Member

KwadFan commented Nov 3, 2022

@KwadFan cloning the ref/installer branch works and is nicely setup. How much longer does it need tested?

Well, I am not fully finished. Wrote a "unit test" today.
That will be merged to develop this night, at least tommorow morning. If that test gets a go by "internal gates" ( named mete and alexz ;) ) it will land in master.

But I aprriciate your tests! Thats a huge help for me, Thank you guys!

@Guilouz
Copy link

Guilouz commented Nov 3, 2022

@KwadFan what about update manager entry for this other branch? When I change to primary branch: ref/installer, it breaks.

Working fine for me

Capture d’écran 2022-11-03 à 23 38 49

Capture d’écran 2022-11-03 à 23 39 00

@jsdokos
Copy link

jsdokos commented Nov 5, 2022

This also appears to be working fine for me on the following:

Fluidd v1.21.1
klipper v0.10.0-620-g11dd273b
moonraker v0.7.1-747-g779997c

@jsdokos
Copy link

jsdokos commented Nov 6, 2022

If you change your update manager to the following it should remove the error in the short term:

[update_manager crowsnest]
type: git_repo
path: ~/crowsnest
primary_branch: ref/installer #master
origin: https://github.com/mainsail-crew/crowsnest.git
managed_services: crowsnest
install_script: tools/install.sh

@KwadFan
Copy link
Member

KwadFan commented Nov 7, 2022

Mentioning #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants