Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Set development mode and activate all debug logs #38

Open
brunomacf opened this issue Apr 13, 2017 · 4 comments
Open

Set development mode and activate all debug logs #38

brunomacf opened this issue Apr 13, 2017 · 4 comments

Comments

@brunomacf
Copy link

At now all logs are disabled by default and this is no satisfactory for work with vamp-docker-images as a development environment for all vamp components. Consider to add a flag to sinalize development mode and activate all debug logs.

@olafmol
Copy link
Member

olafmol commented Apr 13, 2017

@brunomacf is this specifically for the QuickStart package?

@brunomacf
Copy link
Author

brunomacf commented Apr 13, 2017

@olafmol I don't think so, since we can run clique-* packages independently i think we should implement this strategy in each package. By the way, since quickstart is build upon other clique-* modules it will inherit from it. What do you think? Did i understand you right?

@olafmol
Copy link
Member

olafmol commented Apr 13, 2017

i think it makes a lot of sense to have a single flag to enable/disable logging for all components. 👍

@brunomacf
Copy link
Author

brunomacf commented Apr 13, 2017

Me too... but consider this: mesos logs for example are disabled in clique-zookeeper-marathon image and quickstart module inherits from it. So, to enable logging through a DEV flag we should script this up in clique-zookeeper-marathon and then this will be available in quickstart image. The same is true for elasticsearch logs which are disabled (i.e., only error logs) in clique-base image and all other images inherits from it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants