Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level Setting (and Forgetting?) #153

Open
psionic-k opened this issue Sep 23, 2021 · 2 comments
Open

Level Setting (and Forgetting?) #153

psionic-k opened this issue Sep 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@psionic-k
Copy link
Contributor

This is pretty nit-picky, but when setting levels, while the UI works per-key, the level is updated and persisted for the command. The result is that my current demo doesn't work. I need to work around by writing more commands (or a macro). Also, since I can't unset the persisted level, re-evaluating the code doesn't get me back to where I started.

     (transient-define-suffix transient-toys--wave ()
       "Wave at the user"
       :transient t
       (interactive)
       (message (propertize
                 (format "Waves at %s" (current-time-string))
                 'face 'success)))


     (transient-define-prefix transient-toys-levels-of-waves ()
       "Wave at the user"

       [["Essential Commands"
           ("l" "set level" transient-set-level)]

        [2 "Per Group" ; 1 is the default default-child-level
         ("ws" "wave surely" transient-toys--wave) ; 1 is the default default-child-level
         (3"wn" "wave normally" transient-toys--wave)
         (5"wb" "wave non-essentially" transient-toys--wave)]

        [3 "Per Group Somewhat Useful"
           ("wd" "wave definitely" transient-toys--wave)]

        [5 "Per Group Rare"
           ("we" "wave eventually" transient-toys--wave)]])

     (transient-toys-levels-of-waves)

Try setting the level on an individual key such as wd. Due to the command name collision, you will only be able to update the first command found by the lookup, regardless of which key you use subsequently.

I couldn't find anywhere in the menu if there's a function for clearing history.

Also, group levels aren't displayed in the per-key menu even though they have levels and level behavior.

broken-levels

@psionic-k
Copy link
Contributor Author

At second glance, it seems all of the commands with a name get their level updated. The UI only shows one of them being updated. Re-displaying the menu shows that every key gets assigned the same level.

@tarsius tarsius added the enhancement New feature or request label Sep 23, 2021
@tarsius
Copy link
Member

tarsius commented Oct 19, 2023

  • set level per binding
  • set level of a group
  • if group level disables enabled suffix level, use purple
  • allow resetting saved levels
  • allow resetting individual saved level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants