Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about evaluation #19

Closed
ymingxie opened this issue Sep 28, 2020 · 1 comment
Closed

Question about evaluation #19

ymingxie opened this issue Sep 28, 2020 · 1 comment

Comments

@ymingxie
Copy link

Thanks for your nice work!
I have a question about dist1:
https://github.com/magicleap/Atlas/blob/master/atlas/evaluation.py#L102
dist1 should be for each vertex in verts_trgt finding the nearest vertex in verts_pred. But why dist1 is used to compute precision instead of recall?

@zmurez zmurez mentioned this issue Oct 14, 2020
@zmurez
Copy link
Contributor

zmurez commented Oct 14, 2020

Thank you for pointing this out. You are correct that this is a typo (I have submitted a pull request #23). It also means that the column titles in Table 3 in the paper are reversed (I updated the paper on arxiv and it should be live in about a day). This makes the metrics reflect the qualitative evaluation better (all methods do a decent job predicting vertices near the true surface, but they also predict a lot of vertices away from the true surface).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants