Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate incorrect English translation is overriding the French translation. #16

Open
nathanjosiah opened this issue Feb 22, 2019 · 4 comments

Comments

@nathanjosiah
Copy link
Contributor

The string "You added %1 to your <a href=""%2"">shopping cart</a>." has both the correct French translation as well as a duplicate entry further down the file containing the English translation that is overriding the correct French version.

@legendhorus
Copy link
Contributor

Can you please tell me where this string has been translated correctly and where it has not been translated correctly?

@nathanjosiah
Copy link
Contributor Author

@MyoDaisy Inside https://raw.githubusercontent.com/mageplaza/magento-2-french-language-pack/master/fr_FR.csv

Actually, taking another look at this, there is no correct translation. Line 2945 simply needs to be translated. Probably to the same as line 14352:

"You added %1 to your <a href=""%2"">shopping cart</a>.","Vous avez ajouté %1 à <a href=""%2"">votre panier.</a>",module,Magento_Checkout

instead of

"You added %1 to your <a href=""%2"">shopping cart</a>.","You added %1 to your <a href=""%2"">shopping cart</a>.",module,Magento_Checkout

@legendhorus
Copy link
Contributor

Our fr_FR.csv is extended from crowdin. Maybe the user has contributed incorrect translations.
If there is an incorrect translation line, please help me remove it. Thank you!

@nathanjosiah
Copy link
Contributor Author

I opened a PR (#22) to fix a similar line but I'm seeing several lines that are not translated. Seems like they are the lines that contain HTML. For example another line is This is your new encryption key: <span style=""font-family:monospace;"">%1</span>. Be sure to write it down and take good care of it!. I do not know French so I would not be a good contributor to replace them.

I opened this PR due to an internal bug that was opened within Magento that was actually an issue with the translation itself but I am not qualified to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants