-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate incorrect English translation is overriding the French translation. #16
Comments
Can you please tell me where this string has been translated correctly and where it has not been translated correctly? |
@MyoDaisy Inside https://raw.githubusercontent.com/mageplaza/magento-2-french-language-pack/master/fr_FR.csv Actually, taking another look at this, there is no correct translation. Line 2945 simply needs to be translated. Probably to the same as line 14352:
instead of
|
Our fr_FR.csv is extended from crowdin. Maybe the user has contributed incorrect translations. |
I opened a PR (#22) to fix a similar line but I'm seeing several lines that are not translated. Seems like they are the lines that contain HTML. For example another line is I opened this PR due to an internal bug that was opened within Magento that was actually an issue with the translation itself but I am not qualified to fix them. |
The string
"You added %1 to your <a href=""%2"">shopping cart</a>."
has both the correct French translation as well as a duplicate entry further down the file containing the English translation that is overriding the correct French version.The text was updated successfully, but these errors were encountered: