Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken yaml parsing. #21

Open
vetaltor opened this issue Jul 10, 2019 · 2 comments
Open

Broken yaml parsing. #21

vetaltor opened this issue Jul 10, 2019 · 2 comments

Comments

@vetaltor
Copy link

Exception #0 (Exception): Notice: Undefined variable: line in ../vendor/magento/zendframework1/library/Zend/Config/Yaml.php on line 292

foreach ($line as $n => $line) {

@vetaltor
Copy link
Author

Also, foreach ($lines as $n => $line) is not equal to while (list($n, $line) = each($lines)) (from original file https://github.com/zendframework/zf1/blob/136735e776f520b081cd374012852cb88cef9a88/library/Zend/Config/Yaml.php#L292). Since it does reset(), and also in PHP7 foreach loop doesn't utilize array pointer.

@halfpastfouram
Copy link

Yaml parsing is very slow as well. It would be better to use any other Yaml parser than the ZF1 yaml parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants