Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Providing filename with dots is not accepted #39505

Open
1 of 5 tasks
JoryHogeveen opened this issue Dec 24, 2024 · 3 comments
Open
1 of 5 tasks

REST API: Providing filename with dots is not accepted #39505

JoryHogeveen opened this issue Dec 24, 2024 · 3 comments
Assignees
Labels
Issue: ready for confirmation Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.

Comments

@JoryHogeveen
Copy link

JoryHogeveen commented Dec 24, 2024

Preconditions and environment

  • Magento version: 2.4.7-p3
  • Anything else that would help a developer reproduce the bug: Just plain Magento REST API for products

Steps to reproduce

  1. Create a product through the admin without image.
  2. Use the REST API example below
  3. Magento says no.

Expected result

A dot within a filename should be perfectly fine.

Actual result

It's not fine :(

Additional information

REST API request:

{
    "product": {
        "sku": "YOUR_PRODUCT_SKU",
        "media_gallery_entries": [
          {
            "file": "dir/filename.with.dots.jpg",
            "label": "Anything",
            "disabled": false,
            "media_type": "image",
            "position": "0",
            "content": {
              "base64_encoded_data": "YOUR_BASE64_DATA",
              "type": "image/jpeg",
              "name": "some_dir/filename.with.dots.jpg",
            },
            "types": [
              "image",
              "small_image",
              "thumbnail"
            ]
          }
        ],
   }
}

REST API Response:

{
    "message": "The image doesn't exist"
}

This response can be found in: Magento\Catalog\Model\Product\Gallery\Processor::addImage()::L157
https://github.com/magento/magento2/blob/2.4.7-p3/app/code/Magento/Catalog/Model/Product/Gallery/Processor.php#L157

Release note

I've set it to S0 since this option is currently simply not allowed which will result in invalid automated synchronizations between Magento and other systems.

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 24, 2024

Hi @JoryHogeveen. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Dec 24, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. label Dec 24, 2024
@JoryHogeveen
Copy link
Author

Though definitely not the same issue, this topic might be somewhat related: #38641

JoryHogeveen added a commit to SyncEngine/ext-magento2-syncengine that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

2 participants