Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too strict or early rule for Zend_Validate #423

Open
06romix opened this issue Oct 6, 2022 · 6 comments
Open

Too strict or early rule for Zend_Validate #423

06romix opened this issue Oct 6, 2022 · 6 comments
Labels

Comments

@06romix
Copy link

06romix commented Oct 6, 2022

Steps to reproduce

  1. Use Zend_Validate in your extension
  2. Validate extension with the last (26) version of Magento Coding Standard

Expected result

  1. Extension is not valid and there is a correct suggestion or it is not ERROR level but WARNING
  2. Suggested replacement is present in 2.4.0 Magento versions as it is supported to November 28, 2022

Actual result

  1. Extension not valid
  2. Suggested replacement (\Magento\Framework\Validator\ValidatorChain) is missing in 2.4.0-2.4.5

Pull request #420 bring these new changes.

@06romix 06romix added the bug Something isn't working label Oct 6, 2022
@m2-assistant
Copy link

m2-assistant bot commented Oct 6, 2022

Hi @06romix. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@MeCapron
Copy link

MeCapron commented Oct 7, 2022

Agree that this is way too early.

Even the current deployed version by Magento (2.4.5) is not fully working with this rule.

For example, check this file => https://github.com/magento/magento2/blob/2.4.5/app/code/Magento/Eav/Setup/EavSetup.php#L825

Using the EavSetup in custom code leads to this error of coding standards while this is not fully imported yet in Magento side.

@torhoehn
Copy link

Yes, just discovered the same issue here.

@mam08ixo
Copy link

Definitely a bad thing to error out with a suggested replacement that does not even exist in any stable/supported Magento version.

@LukasKiederle
Copy link

We also have the same issue.

@amazur-ext
Copy link

same issue, plus Suggested replacement: Magento\Framework\Validator\ValidateException class is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants