Skip to content

In store pickup silently discards exceptions #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SamJUK opened this issue Apr 24, 2025 · 1 comment · May be fixed by #3422
Open

In store pickup silently discards exceptions #3420

SamJUK opened this issue Apr 24, 2025 · 1 comment · May be fixed by #3422

Comments

@SamJUK
Copy link

SamJUK commented Apr 24, 2025

Currently, exceptions thrown during the in store pickup source distance calculations are being silently discarded. This PR simply logs the exceptions when they are caught.

Preconditions (*)

  1. Google API as Distance Provider
  2. Google API Key with invalid permissions (eg, referrer restrictions applied).

Steps to reproduce (*)

  1. Configure source selection as preconditions
  2. Navigate to checkout, and attempt a pick up at store address lookup

Expected result (*)

  1. Error message in logs outlining, when the lookup failed

Actual result (*)

  1. Error logs are empty, requiring a debugger/source changes to identify the failure reason
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 24, 2025

Hi @SamJUK. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

@SamJUK SamJUK linked a pull request Apr 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: log exceptions during source distance calculation SamJUK/inventory
1 participant
@SamJUK