Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDN and other sets unavailable for drafts #13160

Closed
JayDi85 opened this issue Dec 18, 2024 · 5 comments
Closed

FDN and other sets unavailable for drafts #13160

JayDi85 opened this issue Dec 18, 2024 · 5 comments
Assignees
Labels
bug Bugs and errors

Comments

@JayDi85
Copy link
Member

JayDi85 commented Dec 18, 2024

All sets with real drafts must be available for xmage's draft too (if set contains good amount of implemented cards). Even unfinished sets (must use standard rarity distribution until collation implementation).

Search by hasBoosters = false; // temporary

shot_241218_152641

@JayDi85 JayDi85 added the bug Bugs and errors label Dec 18, 2024
@tiera3
Copy link
Contributor

tiera3 commented Dec 19, 2024

I have (Japanese printrun) collation information for Foundations, so could implement collation for it later today.

https://vm1.substation33.com/tiera/t/lethe/fdn.html

@tiera3
Copy link
Contributor

tiera3 commented Dec 19, 2024

Also pointing out #12978 for MKM collation. (Or please let me know if there is anything more I need to do with it.)

@tiera3
Copy link
Contributor

tiera3 commented Dec 19, 2024

Out of the other ones you've got listed there ...

MarchOfTheMachineTheAftermath shouldn't have boosters. (Arena did offer a MOM draft with one common being replaced with an Aftermath card for a short period of time, but it was not intended to be draftable.)

FoundationsJumpstart isn't draftable either.

tiera3 added a commit to tiera3/mage that referenced this issue Dec 20, 2024
unimplemented cards omitted
also note, xmage currently only allows single picks

magefree#13160
tiera3 added a commit to tiera3/mage that referenced this issue Dec 28, 2024
@JayDi85
Copy link
Member Author

JayDi85 commented Jan 25, 2025

Full sets list with missing boosters in xmage (due mtgjson data):

  • 1998 - UGL - Unglued - boosters: [draft]
  • 2004 - UNH - Unhinged - boosters: [draft]
  • 2017 - UST - Unstable - boosters: [draft]
  • 2020 - J22 - Jumpstart 2022 - boosters: [jumpstart], see Refactor: jumpstart sets must use shared code to generate single boosters #13264
  • 2020 - JMP - Jumpstart - boosters: [jumpstart], see Refactor: jumpstart sets must use shared code to generate single boosters #13264
  • 2020 - SLD - Secret Lair Drop - boosters: [stainedglass-tattoo, stainedglass-uncommon, stainedglass-iwd, blueprint-mk1, stainedglass-c, blueprint-mk2, stainedglass-b, stainedglass-r, stainedglass-g, stainedglass-w, stainedglass-u]
  • 2020 - ZNE - Zendikar Rising Expeditions - boosters: [box-topper]
  • 2021 - DBL - Innistrad: Double Feature - boosters: [draft]
  • 2022 - 30A - 30th Anniversary Edition - boosters: [draft]
  • 2022 - CLB - Commander Legends: Battle for Baldur's Gate - boosters: [set, prerelease, draft, collector, collector-sample]
  • 2022 - UNF - Unfinity - boosters: [draft, box-topper, collector]
  • 2023 - CMM - Commander Masters - boosters: [set, draft, collector, collector-sample]
  • 2023 - MAT - March of the Machine: The Aftermath - boosters: [default, arena, collector]
  • 2023 - WHO - Doctor Who - boosters: [collector, collector-sample]
  • 2024 - ACR - Assassin's Creed - boosters: [default, collector]
  • 2024 - BLB - Bloomburrow - boosters: [play, prerelease, collector, collector-sample]
  • 2024 - CLU - Ravnica: Clue Edition - boosters: [default, box-topper], see Refactor: jumpstart sets must use shared code to generate single boosters #13264
  • 2024 - DSK - Duskmourn: House of Horror - boosters: [play, prerelease, collector, collector-sample]
  • 2024 - FDN - Foundations - boosters: [play, beginner, prerelease, collector]
  • 2024 - J25 - Foundations Jumpstart - boosters: [jumpstart], see Refactor: jumpstart sets must use shared code to generate single boosters #13264
  • 2024 - MB2 - Mystery Booster 2 - boosters: [draft]
  • 2024 - MKM - Murders at Karlov Manor - boosters: [play, play-arena, prerelease, collector, collector-sample]
  • 2024 - PIP - Fallout - boosters: [collector, collector-sample]

JayDi85 added a commit that referenced this issue Jan 26, 2025
JayDi85 added a commit that referenced this issue Jan 27, 2025
JayDi85 added a commit that referenced this issue Jan 27, 2025
* added boosters to Innistrad: Double Feature (DBL);
* added boosters to 30th Anniversary Edition (30A);
* added Chaos Orb reprint to 30A;
* fixed wrong card art styles in ZNE;
@JayDi85 JayDi85 self-assigned this Jan 28, 2025
JayDi85 added a commit that referenced this issue Jan 31, 2025
@JayDi85
Copy link
Member Author

JayDi85 commented Jan 31, 2025

All missed boosters added with simple rarity distribution.

Now any draftable sets with boosters require booster settings (except low implemented sets like un-sets). It's checked by special verify tests due mtgjson data by 18fd7be.

Simple booster can be enabled by this.enablePlayBooster, this.enableArenaBooster and other. If you don't known cards stats then use default this.enablePlayBooster.

Real life boosters with collation or detailed cards distribution can be added later.

@JayDi85 JayDi85 closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors
Projects
None yet
Development

No branches or pull requests

2 participants