Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message with blocker order and face down creatures must contains id #12880

Open
PurpleCrowbar opened this issue Sep 15, 2024 · 3 comments
Open
Assignees
Labels

Comments

@PurpleCrowbar
Copy link
Member

After declaring the order of blockers when multiple of those blockers are face down creatures, it's impossible to know from the log what the order was. In this case, there was a disguised and morphed creature. Both are just listed as "face down creature" twice in the log. Their ID should be in the blocker order log message. See below
image

@xenohedron
Copy link
Contributor

Presumably due to this code which overwrites the log name for empty names, without including the id:

@Override
public String getLogName() {
if (name.isEmpty()) {
if (faceDown) {
return GameLog.getNeutralColoredText("face down creature");
} else {
return GameLog.getNeutralColoredText("a creature without name");
}
}
return GameLog.getColoredObjectIdName(this);
}

@JayDi85 JayDi85 self-assigned this Sep 16, 2024
@Dunkoro
Copy link
Contributor

Dunkoro commented Sep 17, 2024

Preferably all references to any card in chat should include IDs, just like with targetted cards.

@JayDi85
Copy link
Member

JayDi85 commented Sep 17, 2024

Yes. Not only logs, but all GUI related data also must use html related "logName", not text related "IdName" -- it's full html with colored name, id and inner ids (popup card hints uses inner html tags to find and show detailed info/ref). Only few exceptions like exile windows naming (it's not support html yet).

@JayDi85 JayDi85 changed the title Nondescript blocker order with face down creatures Log message with blocker order and face down creatures must contains id Oct 10, 2024
@JayDi85 JayDi85 added the GUI label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants