Unnecessary prompt for "commit" after upgrade script runs

[Danabw]

After the upgrade script completes (./wireguard.sh upgrade) there is a prompt to enter "commit" to save changes, but it appears that the commit/save is already completed by the current version of the script. Should that request to enter "commit" be removed?

[mafredri]

I guess we could hide the output but we'd want to show it if there's an error, not sure if the message is identical on all systems.

[Danabw]

K, thanks for the additional context. It's not a huge deal, just a little confusing for a few moments, and I wanted to be sure you were aware of it. :)

Thanks again for this script, it makes this so easy and fool-proof.

[SlothCroissant]

This is due to the "load" command, right?

reload_config() {
	echo "Reloading configuration..."
	config begin
	config load  <<----
	config commit
	config end
}

When you run this, vyatta says "Load complete. Use 'commit' to make changes active."

[mafredri]

@SlothCroissant yeah, that's correct.

[BrianG61UK]

Could one just add an extra echo to clarify things?

reload_config() {
	echo "Loading configuration..."
	config begin
	config load
	echo "Commiting configuration..."
	config commit
	config end
}