-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog.old
2205 lines (1437 loc) · 69.6 KB
/
ChangeLog.old
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2009-10-02 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Use G_MAXUINT for the timeout when requesting a channel so that the
channel request doesn't timeout.
* src/e-book-backend-tp-cl.c (request_handles_for_contact_list_cb):
2009-10-02 Marco Barisione <[email protected]>
Release 0.4.51
2009-10-02 Marco Barisione <[email protected]>
reviewed by: Joergen Scheibengruber
Update the README as it was really outdated.
* README:
2009-10-02 Marco Barisione <[email protected]>
reviewed by: Joergen Scheibengruber
Change the license from Nokia proprietary to LGPL.
* AUTHORS:
* COPYING:
* src/e-book-backend-tp-cl.c:
* src/e-book-backend-tp-cl.h:
* src/e-book-backend-tp-contact.c:
* src/e-book-backend-tp-contact.h:
* src/e-book-backend-tp-db.c:
* src/e-book-backend-tp-db.h:
* src/e-book-backend-tp-factory.c:
* src/e-book-backend-tp-log.c:
* src/e-book-backend-tp-log.h:
* src/e-book-backend-tp-types.c:
* src/e-book-backend-tp-types.h:
* src/e-book-backend-tp.c:
* src/e-book-backend-tp.h:
* src/test-tpcl.c:
* test/add-contacts.c:
* test/change-aliases.c:
* test/remove-contacts.c:
* test/test-utils.c:
* test/test-utils.h:
2009-09-14 Marco Barisione <[email protected]>
Release 0.4.50
2009-09-04 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Avoid removing the .restore files associated to non-existent accounts.
EDS can be restarted before the mission-control accounts are
restored, so we can end up deleting valid restore files because we
think they are unused.
* src/e-book-backend-tp-db.c (get_restore_db_filename),
(remove_accounts_from_hash_table),
(e_book_backend_tp_db_cleanup_unused_dbs):
2009-08-18 Marco Barisione <[email protected]>
Release 0.4.49
2009-08-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Remove some dead code that has been commented out for months and is
not going to be used again.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_request_avatar_data):
* src/e-book-backend-tp.c:
2009-08-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Emit a critical warning if the unsupported modify_contact method is
called.
* src/e-book-backend-tp.c (e_book_backend_tp_modify_contact):
2009-08-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not leak the McAccountManager used to list the configured accounts.
This memory leak fix also fixes a problem with wake-ups due to the
NameOwnerChanged signal.
* src/e-book-backend-tp-db.c (unref_idle_cb), (manager_ready_cb):
2009-08-14 Marco Barisione <[email protected]>
Release 0.4.48
2009-08-13 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Check whether the connection is not NULL before using it.
The signal for the disconnection from an account can arrive from
mission control before some callbacks are called in response to
something happening in the connection manager. This means we have to
verify if the connection is still valid before using it or we could
pass a NULL connection to telepathy-glib.
* src/e-book-backend-tp-cl.c (verify_is_connected),
(channel_members_changed_closure_free), (update_changed_members),
(members_changed_with_details_cb),
(handle_members_changed_idle_cb), (tp_channel_members_changed_cb),
(tp_channel_ready_cb), (tp_request_channel_cb),
(request_handles_for_contact_list_cb), (aliases_changed_cb),
(avatar_retrieved_cb), (avatar_updated_cb), (presences_changed_cb),
(tp_connection_ready_cb), (capabilities_changed_cb),
(get_capabilities_for_members_cb), (contact_info_changed_cb),
(get_contact_info_for_members_cb),
(verify_is_connected_for_get_channel_members), (get_contacts_cb),
(finish_get_channel_members), (channel_get_all_members_cb),
(get_next_channel_members),
(e_book_backend_tp_cl_run_update_flags),
(e_book_backend_tp_cl_run_add_contact),
(e_book_backend_tp_cl_run_remove_contact),
(e_book_backend_tp_cl_run_unblock_contact),
(e_book_backend_tp_cl_request_avatar_data):
2009-08-13 Marco Barisione <[email protected]>
Release 0.4.47
2009-08-12 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Be sure that the EDS factory is not running after restoring the files
so we don't have to wait for a reboot to see the restored contacts.
The reason for this change is that sometimes the restore of contacts
was not reflected until reboot, the possible cause is that something
else (maybe osso-backup) was restarting the factory before we created
the .restore files.
* data/eds-backend-telepathy-restore.sh:
2009-08-11 Marco Barisione <[email protected]>
reviewed by: Robert Peto
When doing a backup or restore do not execute the script if we are not
doing a backup/restore of the contacts
* data/eds-backend-telepathy-backup.sh:
* data/eds-backend-telepathy-restore.sh:
2009-08-05 Mathias Hasselmann <[email protected]>
Fix warnings reported by the build bot.
* debian/control: Set priority of -dbg package to extra.
2009-08-05 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not empty the hash table of contacts to update before actually
updating the contacts or they will be unreffed and possibly be freed.
* src/e-book-backend-tp.c (flush_db_updates):
2009-08-04 Xavier Claessens <[email protected]>
* src/e-book-backend-tp-contact.c:
* src/e-book-backend-tp-contact.h:
- Add new function e_book_backend_tp_contact_remove_all_master_uids().
- plug a leak in e_book_backend_tp_contact_remove_master_uid().
* src/e-book-backend-tp.c (run_remove_contact, remove_contacts_idle_cb):
- Do not notify views 2 times. The problem was that we give magical
UIDs to e_data_book_respond_remove_contacts() so the notification
were not working properly.
- Make sure to not remove the contact if we are removing some
master_uid but we still have others. In that case, simply notify of
an update of the contact.
- Introduce the new hack for magical UID in form of "rc-uid;*".
In that case, remove all master_uid of the contact but do not remove
it from roster.
2009-08-03 Mathias Hasselmann <[email protected]>
Release 0.4.45
2009-08-03 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Fix a memory leak when adding new contacts.
There was an extra e_book_backend_tp_contact_ref forgot during some
previous change to the code, but this extra reference was also
protecting from crashes in case the contact is removed before storing
it in the DB.
To fix this the extra e_book_backend_tp_contact_ref was removed, but
now the GArrays of contacts to add or update (closure->contacts_to_add
and closure->contacts_to_update) hold a reference to the contacts.
* src/e-book-backend-tp.c (_sync_phase_2_idle_cb),
(tp_cl_get_members_cb):
2009-08-03 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Fix a memory leak: free the old contact's name before assigning the
new one.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_add_contact):
2009-07-31 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Add a cast from gpointer to gchar* to remove a warning about the wrong
type used for the format string "%s".
* src/e-book-backend-tp.c (remove_contacts_idle_cb):
2009-07-27 Marco Barisione <[email protected]>
Release 0.4.44
2009-07-27 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Create the tp-cache directory if it doesn't exist when restoring
backups.
* data/eds-backend-telepathy-restore.sh:
2009-07-23 Travis Reitter <[email protected]>
reviewed by: Jonathon Jongsma
NB#120573 - Duplicate contact created if delete the Gtalk field of an IM
contact
Parse the actual roster contact ID out of the mashed-up
roster-contact-ID-plus-master-IDs string passed into the backend before
giving it to e-data-book-view to notify of the removal.
* src/e-book-backend-tp.c
2009-07-22 Marco Barisione <[email protected]>
Release 0.4.43
2009-07-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
It's possible that we get disconnected from an account before
completely retrieving the contact list, in this case avoid crashing
because the TpConnection has been set to NULL.
* src/e-book-backend-tp-cl.c (channel_get_all_members_cb):
2009-07-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Remove an unused variable.
* src/e-book-backend-tp-cl.c (channel_get_all_members_cb):
2009-07-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make channel_get_all_members_cb more readable.
* src/e-book-backend-tp-cl.c (channel_get_all_members_cb):
2009-07-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not unref a possibly null EContact.
* src/e-book-backend-tp.c (create_contact_idle_cb):
2009-07-22 Marco Barisione <[email protected]>
Release 0.4.42
2009-07-21 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do no send to view contacts that are scheduled for deletion.
When we delete a contact it's kept in our database until it's actually
removed from the server, but we don't have to send it to the views as
it has to be treated by the UI like if it was already deleted.
* src/e-book-backend-tp.c (notify_all_contacts_updated_for_view):
2009-07-20 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Remove directly invalid contacts without trying to remove them from
the roster (as they are not in the roster).
* src/e-book-backend-tp.c (run_remove_contact):
2009-07-17 Marco Barisione <[email protected]>
Release 0.4.41
2009-07-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make a backup of the avatars too. They can be easily retrieved from
the network but having them back just after a restore is nicer for the
user.
* data/eds-backend-telepathy.conf:
2009-07-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Add the files needed by osso-backup to make backups of IM contacts and
restore them.
* configure.ac: Generate data/Makefile
* data/Makefile.am: Add the new data/ dir.
* data/eds-backend-telepathy-backup.sh: Add the backup script.
* data/eds-backend-telepathy-restore.sh: Add the restore script.
* data/eds-backend-telepathy.conf: Add the configuration file telling
to osso-backup which directory to save.
* debian/evolution-data-server-addressbook-backend-telepathy.install:
Install the backup-related files
2009-07-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Restore the DB files created by the backup/restore application before
opening the corresponding books.
* src/e-book-backend-tp-db.c (e_book_backend_tp_db_open_real):
2009-07-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not remove the DBs created by the backup restore program when
cleaning up unused databases.
* src/e-book-backend-tp-db.c (get_restore_db_filename),
(remove_accounts_from_hash_table):
2009-07-17 Marco Barisione <[email protected]>
Release 0.4.40
2009-07-16 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Send an explicit notification of the removal of contacts as soon as
they are marked for deletion and do not wait for them to be actually
removed from the roster.
This was partially working before as libosso-abook considers a contact
removed as soon as e_book_remove returns a success code, but other
views were not notified of this.
* src/e-book-backend-tp.c (delete_contacts),
(remove_contacts_idle_cb):
2009-07-02 Marco Barisione <[email protected]>
Release 0.4.39
2009-07-01 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
If the inspection of some contacts fail we remove them from the list
of contacts passed as argument to the contacts-added signal, but the
condition to verify whether the contacts were inspected or not was
wrong.
* src/e-book-backend-tp-cl.c (remove_invalid_contacts):
2009-07-01 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Remove all the code to update aliases on the server as this is not
supposed to happen anymore.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_add_contact):
* src/e-book-backend-tp-cl.h:
* src/e-book-backend-tp-contact.c
(e_book_backend_tp_contact_update_from_econtact):
* src/e-book-backend-tp-types.h:
* src/e-book-backend-tp.c (tp_cl_aliases_changed_cb),
(run_update_contact), (run_add_contact), (tp_cl_get_members_cb),
(_sync_phase_0_idle_cb), (modify_contact_idle_cb):
2009-07-01 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
When an EBookBackend method is called on a removed book reply with a
proper error instead of not replying anything.
This was problematic as e_book_async_remove is called by libosso-abook
when an account is deleted, so for the same book it's called once per
application using libosso-abook. The first removal attempt was
succeeding while the other ones were emitting a critical warning and
not replying to the D-Bus call, meaning that libebook was thinking
that the EBook was still valid and usable.
* src/e-book-backend-tp.c (modify_contact_idle_cb),
(remove_contacts_idle_cb), (remove_idle_cb):
2009-06-30 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Emit "flags-changed" when we get the initial contact list and not only
when the membership to a contact list changes. If we don't do that
then changes to contact list membership (for instance blocking and
unblocking) that happen when we are offline are ignored.
* src/e-book-backend-tp-cl.c (get_contacts_cb):
2009-06-29 Marco Barisione <[email protected]>
Release 0.4.38
2009-06-22 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Use the sort order that was previously set with a call to
set_view_sort_order when sending all the contacts to the views.
* src/e-book-backend-tp.c (contact_sort_data_new),
(contact_sort_data_free), (contact_sort_data_compare),
(notify_all_contacts_updated_for_view):
2009-06-22 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Implement the set_view_sort_order method on EBookBackendTp.
* src/e-book-backend-tp.c (e_book_backend_tp_set_view_sort_order):
2009-06-22 Marco Barisione <[email protected]>
Release 0.4.37
2009-06-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not leak memory when deleting contacts.
* src/e-book-backend-tp.c (remove_contacts_idle_cb):
2009-06-19 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Update contacts's aliases based on the NICKNAME field and not on FN.
* src/e-book-backend-tp-contact.c
(e_book_backend_tp_contact_update_from_econtact):
2009-06-19 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Make e_book_add_contact unblock contacts.
* src/e-book-backend-tp-types.h:
* src/e-book-backend-tp.c (run_update_contact),
(_sync_phase_0_idle_cb), (modify_contact_idle_cb),
(run_create_contact):
2009-06-19 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Add e_book_backend_tp_cl_run_unblock_contact to unblock contacts.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_unblock_contact):
* src/e-book-backend-tp-cl.h:
2009-06-18 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Set the parameter "X-OSSO-VALID" to "no" when sending vcards of
contacts with invalid IDs to the views. This way the UI can show
contacts with ad invalid ID in a different way.
* src/e-book-backend-tp-contact.c
(e_book_backend_tp_contact_to_econtact):
2009-06-18 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
When a contact ID is invalid keep it around and set a flag saying it's
invalid.
* src/e-book-backend-tp-types.h:
* src/e-book-backend-tp.c (run_add_contact),
(_sync_phase_3_idle_cb), (_sync_phase_0_idle_cb),
(run_create_contact), (create_contact_idle_cb),
(create_contacts_idle_cb):
2009-06-18 Marco Barisione <[email protected]>
Release 0.4.36
2009-06-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Call e_book_backend_set_is_loaded and e_book_backend_set_is_writable
in e_book_backend_tp_load_source and not when the backend is
effectively loaded. This is unfortunate but seems to be needed to make
EDS work.
* src/e-book-backend-tp.c (_sync_phase_0_idle_cb),
(e_book_backend_tp_load_source):
2009-06-17 Marco Barisione <[email protected]>
Release 0.4.35
2009-06-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Cast the EBookBackendTp object passed to e_book_backend_set_is_loaded
and e_book_backend_set_is_writable to EBookBackend to avoid warnings.
* src/e-book-backend-tp.c (_sync_phase_0_idle_cb):
2009-06-17 Marco Barisione <[email protected]>
reviewed by: Robert Peto
Call e_book_backend_set_is_loaded and e_book_backend_set_is_writable
when the backend is loaded.
* src/e-book-backend-tp.c (_sync_phase_0_idle_cb):
2009-06-17 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Handle the case in which the inspection of a handle succeeds but the
contact is already gone so we don't know anything about it anymore.
* src/e-book-backend-tp-cl.c (update_contact_details),
(remove_invalid_contacts), (members_changed_with_details_cb),
(get_contacts_cb):
2009-06-16 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Remove the asserts that were added to help with fixing NB#115549.
* src/e-book-backend-tp-cl.c (update_contact_details),
(members_changed_with_details_cb), (tp_channel_members_changed_cb):
* src/e-book-backend-tp.c (tp_cl_contacts_added):
2009-06-16 Marco Barisione <[email protected]>
Release 0.4.34
2009-06-11 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make safe the functions that use
e_book_backend_tp_cl_run_remove_contact.
* src/e-book-backend-tp.c (run_remove_contact),
(remove_contacts_idle_cb):
2009-06-11 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Forgot to rename e_book_backend_tp_cl_remove_contact to
e_book_backend_tp_cl_run_remove_contact somewhere in the previous
commits.
* src/e-book-backend-tp-cl.h:
* src/e-book-backend-tp.c (_sync_phase_3_idle_cb),
(remove_contact):
2009-06-11 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make EBookBackendTp safe when calling e_book_backend_tp_cl_run_*
functions.
* src/e-book-backend-tp.c (run_update_contact),
(_sync_phase_3_idle_cb), (run_create_contact):
2009-06-10 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make e_book_backend_tp_cl_run_add_contact safe in case some object is
called during the execution of a tp_cli_*_run_* function.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_add_contact):
2009-06-10 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
EBookBackendTpContacts are not GObjects so don't use g_object_(un)ref
on them.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_update_flags),
(e_book_backend_tp_cl_run_update_alias):
2009-06-10 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make e_book_backend_tp_cl_run_update_alias safe in case some object is
called during the execution of a tp_cli_*_run_* function.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_update_alias):
2009-06-10 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make e_book_backend_tp_cl_run_update_flags safe in case some object is
called during the execution of a tp_cli_*_run_* function.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_update_flags):
2009-06-10 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Rename functions that call directly or indirectly some tp_cli_*_run_*
functions so that it's clear that they are going to run the main loop.
* src/e-book-backend-tp-cl.c
(e_book_backend_tp_cl_run_update_flags),
(e_book_backend_tp_cl_run_update_alias),
(e_book_backend_tp_cl_run_add_contact),
(e_book_backend_tp_cl_run_remove_contact):
* src/e-book-backend-tp-cl.h:
* src/e-book-backend-tp.c (run_update_contact),
(_sync_phase_3_idle_cb), (modify_contact_idle_cb),
(run_create_contact), (create_contact_idle_cb),
(create_contacts_idle_cb):
2009-06-09 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Flush the changes to the DB before disposing the backend object. This
is needed both to avoid data loss and to avoid having the timer
callback called after the finalization of the object.
* src/e-book-backend-tp.c (e_book_backend_tp_dispose):
2009-06-08 Marco Barisione <[email protected]>
Release 0.4.33
2009-06-08 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Make the asserts useful for debugging even in case of broken
stack traces using the comma operator like in:
g_assert(("name is null after update", name)).
* src/e-book-backend-tp-cl.c (update_contact_details),
(members_changed_with_details_cb), (tp_channel_members_changed_cb):
2009-06-08 Marco Barisione <[email protected]>
patch by: Travis Reitter
reviewed by: Marco Barisione
Allow a contact to already have a name in
e_book_backend_tp_contact_update_from_econtact in case of merge
* src/e-book-backend-tp-contact.c
(e_book_backend_tp_contact_update_from_econtact):
2009-06-08 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Don't print warnings if requesting some contact lists fail as this is
normal in case the connection manager or the server don't support a
particular contact list.
* src/e-book-backend-tp-cl.c (tp_request_channel_cb),
(request_handles_for_contact_list_cb):
2009-06-05 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Use g_direct_equal for hash tables with integer keys instead of
g_int_equal as g_int_equal is supposed to be used with pointers to
integers.
* src/e-book-backend-tp-cl.c (update_contact_details),
(tp_channel_members_changed_cb):
2009-06-01 Marco Barisione <[email protected]>
Release 0.4.32
2009-06-01 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Add lots of asserts to try to understand what's the cause of bug
NB#115549.
* src/e-book-backend-tp-cl.c (update_contact_details),
(members_changed_with_details_cb), (tp_channel_members_changed_cb):
* src/e-book-backend-tp.c (tp_cl_contacts_added):
2009-05-28 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Don't use the non standard "known" contact list anymore and use
"stored" instead.
* src/e-book-backend-tp-cl.c (contact_flag_to_string),
(contact_list_id_to_string), (get_contact_list_channels):
* src/e-book-backend-tp-types.h:
* src/e-book-backend-tp.c (create_contact):
2009-05-28 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Allow the removal of contacts that are local/remote pending.
* src/e-book-backend-tp-cl.c (tp_channel_members_changed_cb):
2009-05-28 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Don't leak any member of EBookBackendTpContact.
* src/e-book-backend-tp-contact.c (e_book_backend_tp_contact_free):
2009-05-27 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Fix yet another memory leak.
* src/e-book-backend-tp.c (tp_cl_get_members_cb):
2009-05-27 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Do not do an early return when loading contacts from the roster if the
roster is empty or we will fail at removing from the local cache the
deleted contacts.
* src/e-book-backend-tp.c (tp_cl_get_members_cb):
2009-05-27 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
When there are no contacts a GArray of TpHandle was passed to the
callback passed to e_book_backend_tp_cl_get_members instead of a
GArray of EBookBackendTpContact.
* src/e-book-backend-tp-cl.c (finish_get_channel_members):
2009-05-25 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Fix some memory leaks.
* src/e-book-backend-tp.c (_sync_phase_3_idle_cb),
(tp_cl_get_members_cb):
2009-05-25 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Refactor get_next_channel_members to be more readable.
* src/e-book-backend-tp-cl.c (finish_get_channel_members),
(get_next_channel_members):
2009-05-25 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Call the callback passed to e_book_backend_tp_cl_get_members also when
the roster is empty.
* src/e-book-backend-tp-cl.c (get_next_channel_members):
2009-05-25 Marco Barisione <[email protected]>
Release 0.4.31
2009-05-22 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Don't leak the Telepathy channels and connection when the
EBookBackendTpCl is disposed.
* src/e-book-backend-tp-cl.c (free_channels_and_connection),
(e_book_backend_tp_cl_dispose), (connection_status_changed_cb):
2009-05-19 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Change the internal get_db_directory() function so that it allocates
the DB directory path name once and then returns the cached value at
the next invocations.
* src/e-book-backend-tp-db.c (get_db_directory),
(db_filename_for_account),
(e_book_backend_tp_db_cleanup_unused_dbs),
(e_book_backend_tp_db_check_available_disk_space):
2009-05-19 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
When checking for available disk space check it for the partition
where the DB is stored, not for the root directory.
* src/e-book-backend-tp-db.c
(e_book_backend_tp_db_check_available_disk_space):
2009-05-19 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Fix the indentation of
e_book_backend_tp_db_check_available_disk_space().
* src/e-book-backend-tp-db.c
(e_book_backend_tp_db_check_available_disk_space):
2009-05-19 Marco Barisione <[email protected]>
reviewed by: Mathias Hasselmann
Move the function to check for available disk space to
e-book-backend.tp-db.c.
* src/e-book-backend-tp-db.c
(e_book_backend_tp_db_check_available_disk_space):
* src/e-book-backend-tp-db.h:
* src/e-book-backend-tp.c (modify_contact_idle_cb),
(create_contact_idle_cb), (create_contacts_idle_cb),
(remove_contacts_idle_cb):
2009-05-18 Marco Barisione <[email protected]>
Release 0.4.30
2009-05-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Fix some memory leaks.
* src/e-book-backend-tp.c (delete_contacts),
(_sync_phase_3_idle_cb), (remove_contact),
(remove_contacts_idle_cb):
2009-05-18 Marco Barisione <[email protected]>
reviewed by: Travis Reitter
Handle failures to add contacts because of a malformed JID in a
different way from other errors so that the addressbook can still add
the contact.
* src/e-book-backend-tp.c (create_contact),
(create_contact_idle_cb), (create_contacts_idle_cb):
If adding a contact fails because the JID is invalid return
InvalidField instead of Other Error.
2009-05-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
Don't check for the size of the hash table of contacts that need to be
updated as it's a useless optimization.
* src/e-book-backend-tp.c (update_contacts_idle_cb),
(delete_contacts):
2009-05-18 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
When removing a contact be sure to remove it from the hash table of
contacts needing an update. If we don't do this we will send the vcard
of the contact to the views after the deletion so they will
think that the contact was added again.
* src/e-book-backend-tp.c (update_contacts_idle_cb),
(delete_contacts):
2009-05-14 Marco Barisione <[email protected]>
Release 0.4.29
2009-05-14 Marco Barisione <[email protected]>
reviewed by: Robert Peto
We were leaking the backend in the backend functions to create new
contacts or to modify them. According to comments this was done on
purpose to avoid some EDS bugs, but the bug doesn't seem to exist
anymore so remove the hack.
* src/e-book-backend-tp.c (modify_contact_idle_cb),
(create_contact_idle_cb), (create_contacts_idle_cb): Don't leak the
backend.
2009-05-13 Marco Barisione <[email protected]>
reviewed by: Jonathon Jongsma
If a contact doesn't have any alias set then the connection manager
will use the contact ID as alias. In this case don't set the NICKNAME
vcard field.
* src/e-book-backend-tp-contact.c
(e_book_backend_tp_contact_to_econtact):
2009-05-13 Jonathon Jongsma <[email protected]>
Reviewed by: Marco Barisione
* src/e-book-backend-tp-cl.c:
(e_book_backend_tp_cl_remove_contact): Fix a leak by getting rid of
a couple extra refs that were forgotten when the referencing
strategy was changed a couple of commits back
2009-05-13 Tan Miaoqing <[email protected]>