Skip to content

Ternaries should be multi-line with indents #127

Open
@brekk

Description

@brekk

I have code like this:

collatzStep :: Integer -> Integer
collatzStep = (x) => (Math.mod(x, 2) != 0 ? 3 * x + 1 : toInteger(x / 2))

collatz :: Integer -> List Integer
collatz = (step) => (step == 1 ? [1] : [step, ...collatz(collatzStep(step))])

And if possible I'd like for the auto-formatter to make it look like this instead:

collatzStep :: Integer -> Integer
collatzStep = (x) => (
  Math.mod(x, 2) != 0
    ? 3 * x + 1
    : toInteger(x / 2)
)

collatz :: Integer -> List Integer
collatz = (step) => (
  step == 1
    ? [1]
    : [step, ...collatz(collatzStep(step))]
)

I'm open on the indent part, because that can make for nested nested nested ternaries looking extra crazy. (Though usually nested nested nested ternaries are a codesmell)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions