Note on use of tpcp.Algorithm classes

[AKuederle]

I saw that at least in one of the algorithms implemented here (

eargait/eargait/gait_sequence_detection/gait_sequence_detector.py

Line 93 in ffd8336

self.selected_coords = ["x", "y", "z"] # Default coordinates

), have a bunch of loading in the __init__. This is discuraged in the context of tpcp/sklearn and similar frameworks, as the idea is that parameters can be modified even after the init (using set_params) and the assumption is that creating an instance is "cheap" and it is hence done under the hood often (e.g. via .clone).

All logic should be put where it is first needed (aka in detect or train method)

[AKuederle]

Here as well:

eargait/eargait/event_detection/mixed_event_detection.py

Line 78 in ffd8336

if filter: