Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle Dependency / Websocket Requirements #78

Open
ChadSikorra opened this issue Oct 24, 2020 · 1 comment
Open

Guzzle Dependency / Websocket Requirements #78

ChadSikorra opened this issue Oct 24, 2020 · 1 comment

Comments

@ChadSikorra
Copy link

Instead of having Guzzle and Ratchet as hard dependencies, should there instead be other interfaces used so we can use other HTTP clients or websocket clients?

For HTTP clients this is a little more straight forward since PSR-18 exists for that reason. For websockets, something else would have to be made since there is no standardization, but there are competing clients.

One of my use cases for a separate websocket client is so I could use the Swoole websocket client in place of ratchet. Could potentially just create an interface in this library, and then separate out the ratchet implementation into its own repo. Thoughts?

@maclof
Copy link
Owner

maclof commented Oct 26, 2020

@ChadSikorra I completely agree and have been thinking about using the PSR standard instead of a hard dependency on Guzzle

The problem does arise with the websocket client, I do not currently have the time to abstract that implementation out, if there was an existing standard we could use it would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants