Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of contributors to footer #32

Closed
bjankord opened this issue Nov 18, 2014 · 7 comments
Closed

Add list of contributors to footer #32

bjankord opened this issue Nov 18, 2014 · 7 comments

Comments

@bjankord
Copy link
Contributor

I really like how the a11yproject.com displays a list of contributors on their site, makes it feel more like a community-driven effort.

What are your thoughts on adding something like that to this project? There is a jQuery plugin I can add to display contributors in the footer. I'm unsure about adding jQuery to the project for this plugin though. The plugin requires jQuery's getJSON method to call github's API.

@susanjrobertson
Copy link
Collaborator

I don't mind the idea of it, but agree that adding jQuery just for this seems a bit much. What say you @maban, @bradfrost, and other?

@maban
Copy link
Owner

maban commented Nov 18, 2014

I like the idea but this seems a bit much for now. I could add a static link in the footer to the contributors page on GitHub, but I don't really want to add JavaScript if it's not core to the content.

@susanjrobertson
Copy link
Collaborator

I think the link is a good compromise.

@bradfrost
Copy link
Collaborator

Eventually we'll have some additional functionality (such as tagging #27), but if yinz are hardcore to do all that vanilla then be my guest! I will sit back and wallow in a pool of my lacking JS skillz.

@maban
Copy link
Owner

maban commented Nov 18, 2014

I've added a link to the footer, it'll do for now.

@maban maban closed this as completed Nov 18, 2014
@bjankord
Copy link
Contributor Author

Cool, the link seems like a good solution to me. I was thinking jQuery was too heavy for this but didnt want to write a vanilla JS version of the getJSON method to interface with the github API.

@brendanfalkowski
Copy link
Collaborator

Will https://github.com/filamentgroup/shoestring instead of jQuery for a smaller size? I'm lacking on raw JS power also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants