From d7348c727bde56ce773bdec74c1bc584f9dc17ad Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Tue, 17 Aug 2021 17:19:54 +0200 Subject: [PATCH] Remove memoization from remaining resource attribute setters This fixes an issue where updates to some attributes resulting from an API call would not appear on the object passed to that API call. It also makes the setters have a more regular behavior. --- lib/moneybird/resource/contact.rb | 6 +++--- lib/moneybird/resource/documents/purchase_invoice.rb | 6 +++--- lib/moneybird/resource/documents/receipt.rb | 6 +++--- lib/moneybird/resource/estimate.rb | 8 ++++---- lib/moneybird/resource/external_sales_invoice.rb | 4 ++-- lib/moneybird/resource/identity.rb | 2 +- lib/moneybird/resource/recurring_sales_invoice.rb | 4 ++-- lib/moneybird/resource/sales_invoice.rb | 6 +++--- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/lib/moneybird/resource/contact.rb b/lib/moneybird/resource/contact.rb index bd20c67..2170aaa 100644 --- a/lib/moneybird/resource/contact.rb +++ b/lib/moneybird/resource/contact.rb @@ -54,15 +54,15 @@ class Contact ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end def custom_fields=(custom_fields) - @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } + @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } end end end diff --git a/lib/moneybird/resource/documents/purchase_invoice.rb b/lib/moneybird/resource/documents/purchase_invoice.rb index 6f37d74..90e821d 100644 --- a/lib/moneybird/resource/documents/purchase_invoice.rb +++ b/lib/moneybird/resource/documents/purchase_invoice.rb @@ -35,7 +35,7 @@ class PurchaseInvoice ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) @@ -47,11 +47,11 @@ def details=(line_items) end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end def payments=(payments) - @payments ||= payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) } + @payments = payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) } end end end diff --git a/lib/moneybird/resource/documents/receipt.rb b/lib/moneybird/resource/documents/receipt.rb index 8c2cc5f..6d90455 100644 --- a/lib/moneybird/resource/documents/receipt.rb +++ b/lib/moneybird/resource/documents/receipt.rb @@ -35,7 +35,7 @@ class Receipt ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) @@ -47,11 +47,11 @@ def details=(line_items) end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end def payments=(payments) - @payments ||= payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) } + @payments = payments.map{ |payment| Moneybird::Resource::Invoice::Payment.build(payment) } end end end diff --git a/lib/moneybird/resource/estimate.rb b/lib/moneybird/resource/estimate.rb index 1198bb4..76e5ef8 100644 --- a/lib/moneybird/resource/estimate.rb +++ b/lib/moneybird/resource/estimate.rb @@ -48,15 +48,15 @@ class Estimate ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) - @contact ||= Moneybird::Resource::Contact.build(attributes) + @contact = Moneybird::Resource::Contact.build(attributes) end def details=(line_items) - @details ||= line_items.map{ |line_item| Moneybird::Resource::Invoice::Details.build(line_item) } + @details = line_items.map{ |line_item| Moneybird::Resource::Invoice::Details.build(line_item) } end end -end \ No newline at end of file +end diff --git a/lib/moneybird/resource/external_sales_invoice.rb b/lib/moneybird/resource/external_sales_invoice.rb index 0efc5c7..9304f93 100644 --- a/lib/moneybird/resource/external_sales_invoice.rb +++ b/lib/moneybird/resource/external_sales_invoice.rb @@ -38,7 +38,7 @@ class ExternalSalesInvoice ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) @@ -55,7 +55,7 @@ def details=(line_items) end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end end end diff --git a/lib/moneybird/resource/identity.rb b/lib/moneybird/resource/identity.rb index 908ea08..81f5421 100644 --- a/lib/moneybird/resource/identity.rb +++ b/lib/moneybird/resource/identity.rb @@ -24,6 +24,6 @@ class Identity end def custom_fields=(custom_fields) - @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } + @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } end end diff --git a/lib/moneybird/resource/recurring_sales_invoice.rb b/lib/moneybird/resource/recurring_sales_invoice.rb index 5ce5a89..66fc556 100644 --- a/lib/moneybird/resource/recurring_sales_invoice.rb +++ b/lib/moneybird/resource/recurring_sales_invoice.rb @@ -40,7 +40,7 @@ class RecurringSalesInvoice ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) @@ -52,7 +52,7 @@ def details=(line_items) end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end end end diff --git a/lib/moneybird/resource/sales_invoice.rb b/lib/moneybird/resource/sales_invoice.rb index 45bed49..67bac57 100644 --- a/lib/moneybird/resource/sales_invoice.rb +++ b/lib/moneybird/resource/sales_invoice.rb @@ -55,7 +55,7 @@ class SalesInvoice ) def notes=(notes) - @notes ||= notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } + @notes = notes.map{ |note| Moneybird::Resource::Generic::Note.build(note) } end def contact=(attributes) @@ -82,11 +82,11 @@ def details=(line_items) end def events=(events) - @events ||= events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } + @events = events.map{ |event| Moneybird::Resource::Generic::Event.build(event) } end def custom_fields=(custom_fields) - @custom_fields ||= custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } + @custom_fields = custom_fields.map { |custom_field| Moneybird::Resource::CustomField.build(custom_field) } end end end