Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

URL parsing error not handled correctly #46

Open
chrisdinn opened this issue May 28, 2015 · 0 comments
Open

URL parsing error not handled correctly #46

chrisdinn opened this issue May 28, 2015 · 0 comments

Comments

@chrisdinn
Copy link
Contributor

Malformed URLs through an exception in a manner that''s inappropriate. It happens so early in the request flow that the request isn't even seen by the application.

java.lang.IllegalArgumentException: URLDecoder: Incomplete trailing escape (%) pattern
at java.net.URLDecoder.decode(URLDecoder.java:187) ~[na:1.7.0_67]
at smoke.Request$class.decode(Request.scala:93) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.decode(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.Request$$anonfun$parseParams$2.apply(Request.scala:88) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.Request$$anonfun$parseParams$2.apply(Request.scala:87) ~[smoke_2.10-2.1.0.jar:2.1.0]
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) ~[scala-library-2.10.4.jar:na]
at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) ~[scala-library-2.10.4.jar:na]
at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) ~[scala-library-2.10.4.jar:na]
at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108) ~[scala-library-2.10.4.jar:na]
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) ~[scala-library-2.10.4.jar:na]
at scala.collection.mutable.ArrayOps$ofRef.map(ArrayOps.scala:108) ~[scala-library-2.10.4.jar:na]
at smoke.Request$class.parseParams(Request.scala:87) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.parseParams(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.Request$class.formParams(Request.scala:46) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.formParams$lzycompute(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.formParams(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.Request$class.params(Request.scala:50) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.params$lzycompute(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at smoke.netty.NettyRequest.params(NettyRequest.scala:22) ~[smoke_2.10-2.1.0.jar:2.1.0]
at com.mdialog.odsm.StreamsApi.authenticate(StreamsApi.scala:33) ~[on_demand_stream_manager-5.8.0.jar:na]
at com.mdialog.odsm.StreamsApi$$anonfun$handleRequest$1.apply(StreamsApi.scala:86) ~[on_demand_stream_manager-5.8.0.jar:na]
at com.mdialog.odsm.StreamsApi$$anonfun$handleRequest$1.apply(StreamsApi.scala:86) ~[on_demand_stream_manager-5.8.0.jar:na]
at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24) ~[scala-library-2.10.4.jar:na]
at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24) ~[scala-library-2.10.4.jar:na]
at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:41) [akka-actor_2.10-2.3.4.jar:na]
at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:393) [akka-actor_2.10-2.3.4.jar:na]
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) [scala-library-2.10.4.jar:na]
at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) [scala-library-2.10.4.jar:na]
at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) [scala-library-2.10.4.jar:na]
at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) [scala-library-2.10.4.jar:na]

damienlevin pushed a commit to damienlevin/smoke that referenced this issue Apr 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant