From 0e2e475523f93d7205e9f42247b26bc8e1a5ce55 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 17 Jan 2025 03:28:14 +0000 Subject: [PATCH 1/2] Bump Microsoft.Extensions.Http.Polly from 9.0.0 to 9.0.1 Bumps [Microsoft.Extensions.Http.Polly](https://github.com/dotnet/aspnetcore) from 9.0.0 to 9.0.1. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](https://github.com/dotnet/aspnetcore/compare/v9.0.0...v9.0.1) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- src/Lynx/Lynx.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Lynx/Lynx.csproj b/src/Lynx/Lynx.csproj index c65d87401..ad42c9d24 100644 --- a/src/Lynx/Lynx.csproj +++ b/src/Lynx/Lynx.csproj @@ -19,7 +19,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + all From fb020e9b7b81ef4413c37cee9aba442516d76e45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eduardo=20C=C3=A1ceres?= Date: Fri, 17 Jan 2025 05:49:34 +0100 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A7=B9=20Remove=20unneeded=20branch?= =?UTF-8?q?=20in=20`Position.MakeMove`=20(#1385)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Lynx/Model/Position.cs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/Lynx/Model/Position.cs b/src/Lynx/Model/Position.cs index 780625573..fce994312 100644 --- a/src/Lynx/Model/Position.cs +++ b/src/Lynx/Model/Position.cs @@ -123,13 +123,6 @@ public GameState MakeMove(Move move) int piece = move.Piece(); int promotedPiece = move.PromotedPiece(); - // King (and castling) moves require calculating king buckets twice, so skipping incremetal eval for those cases for now - _isIncrementalEval = _isIncrementalEval - && !(piece == (int)Piece.K - || piece == (int)Piece.k - //|| move.IsCastle() // Not needed for now, see CastlingMovesAreKingMoves test - ); - var newPiece = piece; if (promotedPiece != default) { @@ -166,6 +159,10 @@ public GameState MakeMove(Move move) } else if (piece == (int)Piece.K || piece == (int)Piece.k) { + // King (and castling) moves require calculating king buckets twice and recalculating all related parameters, so skipping incremental eval for those cases for now + // No need to check for move.IsCastle(), see CastlingMovesAreKingMoves test + _isIncrementalEval = false; + _kingPawnUniqueIdentifier ^= sourcePieceHash ^ targetPieceHash;