Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmpfs unsupported mount options tmpcopyup, rprivate #30

Open
r10r opened this issue Feb 11, 2021 · 3 comments
Open

tmpfs unsupported mount options tmpcopyup, rprivate #30

r10r opened this issue Feb 11, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@r10r
Copy link
Contributor

r10r commented Feb 11, 2021

crio-o seems adds the mount options rprivate and tmpcopyup to tmpfs container mounts. See drachenfels-de/lxcri-defork#13

As far as I can see these options are added to all tmpfs mounts but /dev This includes:

/run
/run/lock
/tmp
/var/log/journal

The kernel log (dmesg) then shows the following errors:

[721537.855698] tmpfs: Unknown parameter 'rprivate'
[721602.257009] tmpfs: Unknown parameter 'tmpcopyup'

The mount options rprivate and tmpcopyup are not support for tmpfs. See man 5 tmpfs

Platform

Linux k8s-cluster2-controller 5.10.11-arch1-1 drachenfels-de/lxcri#7 SMP PREEMPT Wed, 27 Jan 2021 13:53:16 +0000 x86_64 GNU/Linux
@r10r
Copy link
Contributor Author

r10r commented Feb 11, 2021

https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc3

Add a tmpcopyup mount extension for tmpfs mounts that are mounted over
already existing directories, allowing for the contents of a volume to
be copied up transparently. #845

@r10r r10r changed the title unsupported mount option tmpcopyup tmpfs unsupported mount option tmpcopyup, rprivate Feb 11, 2021
@r10r
Copy link
Contributor Author

r10r commented Feb 11, 2021

Can be easily reproduced with a plain lxc container created with lxc cmdline tools:

lxc-create -n test-mount --template download -- --dist ubuntu --release xenial --arch amd64
#
cat  >> /usr/local/var/lib/lxc/test-mount/config  <<EOF
lxc.mount.entry = tmpfs foobar tmpfs rw,rprivate,noexec,nosuid,nodev,tmpcopyup,create=dir
lxc.log.file = /dev/stderr
lxc.log.level = DEBUG
EOF
#
lxc-start -n  test-mount
lxc-start test-systemd 20210211111711.916 ERROR    utils - utils.c:safe_mount:1204 - Invalid argument - Failed to mount "tmpfs" onto "/usr/local/lib/lxc/rootfs/foobar"
lxc-start test-systemd 20210211111711.916 ERROR    conf - conf.c:mount_entry:1966 - Invalid argument - Failed to mount "tmpfs" on "/usr/local/lib/lxc/rootfs/foobar"
lxc-start test-systemd 20210211111711.916 ERROR    conf - conf.c:lxc_setup:3442 - Failed to setup mount entries
lxc-start test-systemd 20210211111711.916 ERROR    start - start.c:do_start:1264 - Failed to setup container "test-systemd"

@r10r r10r changed the title tmpfs unsupported mount option tmpcopyup, rprivate tmpfs unsupported mount options tmpcopyup, rprivate Feb 11, 2021
@r10r r10r transferred this issue from another repository Mar 24, 2021
@r10r r10r transferred this issue from another repository Apr 8, 2021
@r10r
Copy link
Contributor Author

r10r commented Apr 21, 2021

This is related to #31

@r10r r10r added the help wanted Extra attention is needed label Apr 30, 2021
r10r added a commit to drachenfels-de/lxc that referenced this issue Jun 23, 2021
Do not append the propgation options to the mount data.
Filesystems fail to mount if the mount data contains
propagation options.

See also lxc/lxcri#30

Signed-off-by: Ruben Jenster <[email protected]>
r10r added a commit to drachenfels-de/lxc that referenced this issue Jun 30, 2021
Do not append the propgation options to the mount data.
Filesystems fail to mount if the mount data contains
propagation options.

See also lxc/lxcri#30

Signed-off-by: Ruben Jenster <[email protected]>
r10r added a commit to drachenfels-de/lxc that referenced this issue Dec 12, 2023
Do not append the propgation options to the mount data.
Filesystems fail to mount if the mount data contains
propagation options.

See also lxc/lxcri#30

Signed-off-by: Ruben Jenster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

1 participant