Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to activate LVM snapshot #1216

Closed
skyxx opened this issue Sep 12, 2024 · 1 comment
Closed

Add support to activate LVM snapshot #1216

skyxx opened this issue Sep 12, 2024 · 1 comment

Comments

@skyxx
Copy link

skyxx commented Sep 12, 2024

Request description

Hi, it will be nice to add support activate + mount existing LVM snapshots for storage volumes and containers.

When using LVM storage driver, created snapshots are not accesible as LV is not accesible and not mounted.
Only path /var/lib/incus/storage-pools/<pool_name>/<type>-snapshots/default_<volume_name>/<snapshot_name> is created but no data accessible.

When using BTRFS storage driver after creating snapshot data from it are available automaticaly.
/var/lib/incus/storage-pools/<pool_name>/<type>-snapshots/default_<volume_name>/<snapshot_name>

So something like this will be nice:
incus snapshot activate <instance> <snapshot_name>
incus snapshot deactivate <instance> <snapshot_name>

incus storage volume snapshot activate <pool_name> <volume_name> <snapshot_name>
incus storage volume snapshot deactivate <pool_name> <volume_name> <snapshot_name>

@stgraber
Copy link
Member

We're definitely not going to be doing that. In general we never want anyone to directly access files through /var/lib/incus and we definitely will not be adding a user facing API to trigger more mounts happening in there.

For a proper way to access snapshot data, we have: #1174

@stgraber stgraber closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants