snmp: remove unused prev field from snmp_varbind

j123b567 · yarrick · commit 5ee5801c2c9b · 2024-11-29T18:26:07.000+01:00
diff --git a/src/apps/snmp/snmp_msg.c b/src/apps/snmp/snmp_msg.c
@@ -328,7 +328,6 @@ snmp_receive(void *handle, struct pbuf *p, const ip_addr_t *source_ip, u16_t por
         struct snmp_varbind vb;
 
         vb.next = NULL;
-        vb.prev = NULL;
         vb.type = SNMP_ASN1_TYPE_COUNTER32;
         vb.value_len = sizeof(u32_t);
 
diff --git a/src/apps/snmp/snmp_traps.c b/src/apps/snmp/snmp_traps.c
@@ -351,7 +351,6 @@ snmp_send_trap_or_notification_or_inform_generic(struct snmp_msg_trap *trap_msg,
                                                      /* First varbind is used to store sysUpTime */
                                                      {
                                                        NULL,                            /* *next */
-                                                       NULL,                            /* *prev */
                                                        {                                /* oid */
                                                          8,                             /* oid len */
                                                          {1, 3, 6, 1, 2, 1, 1, 3}       /* oid for sysUpTime */
@@ -363,7 +362,6 @@ snmp_send_trap_or_notification_or_inform_generic(struct snmp_msg_trap *trap_msg,
                                                      /* Second varbind is used to store snmpTrapOID */
                                                      {
                                                        NULL,                            /* *next */
-                                                       NULL,                            /* *prev */
                                                        {                                /* oid */
                                                          10,                            /* oid len */
                                                          {1, 3, 6, 1, 6, 3, 1, 1, 4, 1} /* oid for snmpTrapOID */
diff --git a/src/include/lwip/apps/snmp.h b/src/include/lwip/apps/snmp.h
@@ -55,8 +55,6 @@ struct snmp_varbind
 {
   /** pointer to next varbind, NULL for last in list */
   struct snmp_varbind *next;
-  /** pointer to previous varbind, NULL for first in list */
-  struct snmp_varbind *prev;
 
   /** object identifier */
   struct snmp_obj_id oid;

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,6 @@ struct snmp_varbind`
`55`	`55`	`{`
`56`	`56`	`/** pointer to next varbind, NULL for last in list */`
`57`	`57`	`struct snmp_varbind *next;`
`58`		`- /** pointer to previous varbind, NULL for first in list */`
`59`		`- struct snmp_varbind *prev;`
`60`	`58`
`61`	`59`	`/** object identifier */`
`62`	`60`	`struct snmp_obj_id oid;`