Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about the HAL article #189

Open
maelle opened this issue Sep 28, 2023 · 3 comments
Open

question about the HAL article #189

maelle opened this issue Sep 28, 2023 · 3 comments
Assignees
@lvaudor
Labels
documentation Improvements or additions to documentation

Comments

@maelle
Copy link
Collaborator

maelle commented Sep 28, 2023

@lvaudor there's a ligne where you filter the names corresponding to your lab but without doing any arranging first, should we amend it?
@maelle
Copy link
Collaborator Author

maelle commented Sep 28, 2023

I'd suggest fixing after we merge the PR.

@maelle maelle added the documentation Improvements or additions to documentation label Sep 28, 2023
@lvaudor
Copy link
Owner

lvaudor commented Oct 2, 2023

I'm not sure how to arrange this... I do it entirely based on my "expert knowledge" of my (tentacular) lab ;-)

@maelle
Copy link
Collaborator Author

maelle commented Oct 2, 2023

I mean the order of the names could change, which would make your code wrong, so could you add a call to spq_arrange() before the filtering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvaudor lvaudor

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maelle @lvaudor