Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support H packet #19

Open
tromey opened this issue Dec 20, 2017 · 3 comments
Open

support H packet #19

tromey opened this issue Dec 20, 2017 · 3 comments

Comments

@tromey
Copy link
Collaborator

tromey commented Dec 20, 2017

The H packet is needed to set state for other packets.

It's easy enough to parse and forward to the handlers; but I wonder if it would make sense to either provide a mixin that handles the state management; or to handle the state directly in the implementation.

@tromey
Copy link
Collaborator Author

tromey commented Dec 20, 2017

I think only Hg is needed, the other H packets are obsoleted by vCont.

tromey added a commit to tromey/rust-gdb-remote-protocol that referenced this issue Dec 20, 2017
This is the simplest fix for bug luser#19.
tromey added a commit to tromey/rust-gdb-remote-protocol that referenced this issue Dec 20, 2017
This is the simplest fix for bug luser#19.
@luser
Copy link
Owner

luser commented Dec 20, 2017

It's easy enough to parse and forward to the handlers; but I wonder if it would make sense to either provide a mixin that handles the state management; or to handle the state directly in the implementation.

I don't have strong feelings here, but I guess if it's just a bit of state then there's no reason we couldn't have this crate store the current thread, and any command that operates on the current thread could just have a Handler method that takes a thread parameter, to which we'd pass the current thread. Probably the only weirdness here would be "what's the default current thread?" If there's a sensible answer there, then that seems workable.

@tromey
Copy link
Collaborator Author

tromey commented Dec 27, 2017

Since we need Hc after all (for bc and bs), and since I think it's best to have just one "continue" method on Handler, I think it would be best to keep the state locally so that these cases can be unified with vCont.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants