Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Causes certain pages to not load properly #305

Open
Merith-TK opened this issue Aug 13, 2020 · 1 comment · May be fixed by #316
Open

Causes certain pages to not load properly #305

Merith-TK opened this issue Aug 13, 2020 · 1 comment · May be fixed by #316

Comments

@Merith-TK
Copy link

A perfect example of this is https://example.com

DevTools failed to load SourceMap: Could not load content for chrome-extension://hhhpdkekipnbloiiiiaokibebpdpakdp/content_script.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

from the chrome console,

on firefox it complains about two css rules.

I found out about this when one of my friends who uses this extension, visited my site, https://merith.tk, which caused it to load improperly. We determined it was this extension by them disabling all others until the page was working as intended.

The issue appears to be that saka injects some HTML into the webpage, which appears to attempt to load a resource from the chrome extension, which last i was aware (i may be wrong) was not allowed by chrome for security purposes

The extension also fails to run on these pages,
@ScoreUnder
Copy link

ScoreUnder commented Dec 8, 2020 •
edited
Loading

screenshot of example.com with web inspector open

It seems like the <div> tags generated by saka-key are having their style overridden by the CSS on the page, causing them to appear solid and prominent above other content. There may be a need to re-style saka-key content specifically to undo non-default CSS settings, but I worry that that might be a lot of effort.

Though it looks like some effort was made to do this for the root <div> element, so perhaps whatever defines those rules can have its selector modified to point to the children too?

ScoreUnder added a commit to ScoreUnder/saka-key that referenced this issue Dec 8, 2020
@ScoreUnder
Fix style on sites like example.com
79693fe 
Fix lusakasa#305:
Stop websites from accidentally re-styling div elements belonging to
saka-key.
@ScoreUnder ScoreUnder linked a pull request Dec 8, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix style on sites like example.com ScoreUnder/saka-key
2 participants
@ScoreUnder @Merith-TK