Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with compiling dev branch #34

Open
AntonioCS opened this issue Dec 27, 2015 · 12 comments
Open

Issues with compiling dev branch #34

AntonioCS opened this issue Dec 27, 2015 · 12 comments

Comments

@AntonioCS
Copy link

I have compiled the master branch (before the addition of liburi) and I had no issues, but after switching to the dev branch and doing: make

I got the following output:

gcc -ggdb -o3 -w -I includes -I /usr/include/libxml2 -fpic -c -o pageProcesser/cs_page.o pageProcesser/cs_page.c
In file included from pageProcesser/cs_page.c:1:0:
includes/cs_page.h:37:3: error: unknown type name ‘cs_page’
cs_page pages;
^
includes/cs_page.h:42:17: error: unknown type name ‘cs_page’
void clear_page(cs_page *p);
^
includes/cs_page.h:44:19: error: unknown type name ‘cs_page’
void destroy_page(cs_page *p);
^
includes/cs_page.h:46:14: error: unknown type name ‘cs_page’
int new_page(cs_page *p, unsigned int capacity);
^
includes/cs_page.h:48:14: error: unknown type name ‘cs_page’
int set_page(cs_page *p, char
context, unsigned int length);
^
pageProcesser/cs_page.c:9:17: error: unknown type name ‘cs_page’
void clear_page(cs_page p) {
^
pageProcesser/cs_page.c:23:19: error: unknown type name ‘cs_page’
void destroy_page(cs_page *p) {
^
pageProcesser/cs_page.c:35:14: error: unknown type name ‘cs_page’
int new_page(cs_page *p, unsigned int capacity) {
^
pageProcesser/cs_page.c:55:14: error: unknown type name ‘cs_page’
int set_page(cs_page *p, char
context, unsigned int length) {
^
make: *** [pageProcesser/cs_page.o] Error 1

Am I missing anything? Or is this an actual makefile issue?

@ghost
Copy link

ghost commented Dec 27, 2015

in includes/cs_page.h <-- ADD :

#include "CS.h"
#define BadPageID ((unsigned int) -1)
typedef unsigned int page_queue_id;
typedef unsigned int page_id;

in includes/cs_string.h <-- ADD:

#include <stdbool.h>

in pageProcesser/page_queue.c line 76:

remove int i in for loop, [ c99 loop variable declaration ].

then you are good to go. This is a dirty fix if you just want to test the dev branch.
Probably tomorrow guys will take care of that .

@luohaha
Copy link
Owner

luohaha commented Dec 28, 2015

I think about leave this job to mzer0-yu. Everyone should be responsible for his code. Make sure it run normally before push.

@AntonioCS
Copy link
Author

@luohaha Yes that should be obvious. The code should work on their branch and then merged to dev or master

@luohaha
Copy link
Owner

luohaha commented Dec 28, 2015

I have moved luohaha/CSpider to xonce/CSpider already.

@mzer0-yu
Copy link
Contributor

feel free to modify.

@mzer0-yu
Copy link
Contributor

@luohaha why?

@luohaha
Copy link
Owner

luohaha commented Dec 28, 2015

@mzer0-yu Make sure your code work on your branch, and then push. If you can't, do not push it.

@mzer0-yu
Copy link
Contributor

@luohaha OK. Something changed in my codes since the URI part pushed. Why moved to the xonce repository?

@luohaha
Copy link
Owner

luohaha commented Dec 28, 2015

I accept @mitghi 's suggestion to do that. I am kind of busy to deal with CSpider alone.

@mzer0-yu
Copy link
Contributor

@mitghi the moved one didn't have a dev branch.

@ghost
Copy link

ghost commented Dec 28, 2015

@mzer0-yu dev branch has been added.

@mzer0-yu
Copy link
Contributor

@luohaha @mitghi
I found the reason of failing in master branch: one of PRs wasn't merged, whatever it should have been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants