Warnings as Errors Request

[JayMales]

Could I request a command line arg that would treat warnings as errors.

This would be great!

Thanks

[arichard4]

Can you clarify what you mean by that? Eg is there a specific example you can give? What’s the current warning/error distinction, do you mean syntax errors?

[JayMales]

Hey,

So we have been using this app for about 6 months now and we had warnings turn on. We have slowly been removing ALL the warnings and as of today we have finally got rid of them. Lots of these warnings would/could cause massive issues. So from now on we want to enforce warnings as errors. There is options in visual studio to count warnings as errors. That does not work for these projects :\ so it would be nice if we could pass in a command line arg and just treat warnings as errors (but still not include the excluded warnings)

[arichard4]

Warnings vs. errors are decided on in the function count_warnings_errors in format.lua:

local function count_warnings_errors(events)
   local warnings, errors = 0, 0

   for _, event in ipairs(events) do
      if event.code:sub(1, 1) == "0" then
         errors = errors + 1
      else
         warnings = warnings + 1
      end
   end

   return warnings, errors
end

If you want a quick fix, you can make this function count everything as an error locally.

Longer-term, I don't think an "only errors" mode makes sense, but plausibly luacheck ought to expose a config option for which events are considered errors.

There is options in visual studio to count warnings as errors. That does not work for these projects :\

I'm not sure what you mean by this, but this feels like a separate bug in whatever glue project you are using to link luacheck to visual studio?

[alerque]

@JayMales What difference does it make to you? Ore you just looking for the exit code or are you parsing the output to read whether it is a warning or error?

[cooljeanius]

@JayMales What difference does it make to you? Ore you just looking for the exit code or are you parsing the output to read whether it is a warning or error?

At least in my case, it's whichever one of those that GitHub Actions uses to determine whether the workflow failed or not.