Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LxDepthService (z-index) #472

Open
Ikkyusan1 opened this issue Nov 9, 2016 · 0 comments
Open

LxDepthService (z-index) #472

Ikkyusan1 opened this issue Nov 9, 2016 · 0 comments

Comments

@Ikkyusan1
Copy link

The depth service in its current state is pretty useless, and can in fact be troublesome.
The base depth is set to 1000, which is a completely arbitrary value. Plus, everytime a directive registers itself on this service, the depth is incremented by 1. (ex: everytime the DatePicker or LxSelect dropdown is shown, the value get +1). This value is shared with every directives that use the service...

I would have thought the base value to be based on a parent element's depth (but it's hard to determine which one, if that's even possible), and to stay the same afterwards for a particular directive.

Wouldn't it be better to set the depths exclusively with css rules ? Or set the depth of the directives when they're instanciated ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant