Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide register page #952

Open
phls opened this issue Dec 2, 2023 · 12 comments
Open

Hide register page #952

phls opened this issue Dec 2, 2023 · 12 comments

Comments

@phls
Copy link

phls commented Dec 2, 2023

Hi,

First of all, great software!

On my instance, I'm using OIDC Login with GitLab.

Would be possible hide the register page to allow login only with OIDC?

Best regards,

@lukevella
Copy link
Owner

Currently no but it's a sensible request and I will do my best to cater for it. It's just not a priority at the moment so no ETA yet.

@icsy7867
Copy link

Instead of making a new request, I thought I would add to this. I have OIDC working with ADFS now.

While I support hiding the register button AND hiding the email login portion of the login page, perhaps there is an easier solution?

Looking at the code:

              {hasOIDCProvider ? (
                <Button
                  icon={LogInIcon}
                  size="lg"
                  onClick={() => signIn("oidc")}
                >

Instead of making this an "OnClick", why not just automatically use the OIDC login? Since our organization forces OIDC/SSO/SAML, having a user click a "Login using SSO" button is superfluous. Instead of listening for the "OnClick" event, simply initiate signIn("oidc") immediately, forcing login with SSO

@lukevella
Copy link
Owner

Instead of making this an "OnClick", why not just automatically use the OIDC login? Since our organization forces OIDC/SSO/SAML, having a user click a "Login using SSO" button is superfluous. Instead of listening for the "OnClick" event, simply initiate signIn("oidc") immediately, forcing login with SSO

Maybe down the road. SSO is still a relatively new feature and it's not ready to be the only way to login. Remember #986? 😅

@icsy7867
Copy link

Fair enough. I was just excited to have it all working now. I appreciate your hard work and quick replies.

Also, I wouldnt recommend forcing OIDC/SSO by default, but having a config/environment variable for OIDC_FORCE_AUTH=True

or something like that. But I will defer to your design of course. Thank you for getting OIDC working. My organization requires 2-factor, and this really helps check that box.

@port19x
Copy link

port19x commented Feb 1, 2024

Just chiming in, I'm trying to host rally behind a reverse proxy and don't want or need any authentication.
Is it possible to run rally that way and handle any potential future auth on the proxy layer?

@lukevella
Copy link
Owner

Just chiming in, I'm trying to host rally behind a reverse proxy and don't want or need any authentication. Is it possible to run rally that way and handle any potential future auth on the proxy layer?

No, I don't think that's likely to happen.

@EduNetEurope
Copy link

We would like to restrict new user registration to a domain.

@lukevella
Copy link
Owner

We would like to restrict new user registration to a domain.

Should be possible using ALLOWED_EMAILS

https://support.rallly.co/self-hosting/configuration-options

@trmendes
Copy link

Some self-hosted apps have an ENVIRONMENT variable to disable the creation of new users.

That is useful in case the host admin wants to be the only one to use its own server to create new polls and share the links for friends and others to participate.

Is there a way to block the creation of new users using the ALLOWED_EMAILS?

@icsy7867
Copy link

Some self-hosted apps have an ENVIRONMENT variable to disable the creation of new users.

That is useful in case the host admin wants to be the only one to use its own server to create new polls and share the links for friends and others to participate.

Is there a way to block the creation of new users using the ALLOWED_EMAILS?

Can't you just set the allowed_emails to something that can never be true? I.e
*@thisisnotpossible.org

@juergenroesch
Copy link

that doesn't work - mails of the SSO User are validated against that list. if you set that to youwillneverhavethataddress.org then nobody could login anyhow

@andrin55
Copy link

Hi

Is there any work going on regarding this feature? It would be nice to have the option to automatically redirect to the OIDC login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants