Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable interface #1

Open
glombek opened this issue May 29, 2019 · 1 comment
Open

Pluggable interface #1

glombek opened this issue May 29, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@glombek
Copy link

glombek commented May 29, 2019

I wonder if this might work well as an extendable pattern with multiple media sources.

ie IMediaSource (with implementations Unsplash, Giphy, Media library, etc)
@lukehook
Copy link
Owner

Great shout, there are slight nuances between them but this would make it much more flexible (although I'd probably have to change the name which I was very proud of).

Giphy and Unsplash API calls and returned JSON are actually relatively similar - wouldn't be too much effort. Would have to scope out how we select the source in the UI too

@lukehook lukehook added enhancement New feature or request help wanted Extra attention is needed labels May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glombek @lukehook