Merge pull request #30 from lukaswagner/fix/29-column-get-set

lukaswagner · web-flow · commit 605556a19bc9 · 2022-02-03T13:33:03.000+01:00
fix find predicate
diff --git a/packages/csv-parser/src/types/column/baseColumn.ts b/packages/csv-parser/src/types/column/baseColumn.ts
@@ -39,12 +39,13 @@ export abstract class BaseColumn<T, C extends BC<T>> implements IColumn<T, C> {
     }
 
     public get(index: number): T {
-        const chunk = this._chunks.find((c) => c.offset < index && c.offset + c.length >= index);
+        const chunk = this._chunks.find((c) => c.offset <= index && c.offset + c.length > index);
         if (!chunk) throw new Error('Invalid index.');
         return chunk.get(index - chunk.offset);
     }
+
     public set(index: number, value: T): void {
-        const chunk = this._chunks.find((c) => c.offset < index && c.offset + c.length >= index);
+        const chunk = this._chunks.find((c) => c.offset <= index && c.offset + c.length > index);
         if (!chunk) throw new Error('Invalid index.');
         chunk.set(index - chunk.offset, value);
     }

Original file line number	Diff line number	Diff line change
`@@ -39,12 +39,13 @@ export abstract class BaseColumn<T, C extends BC<T>> implements IColumn<T, C> {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`public get(index: number): T {`
`42`		`- const chunk = this._chunks.find((c) => c.offset < index && c.offset + c.length >= index);`
	`42`	`+ const chunk = this._chunks.find((c) => c.offset <= index && c.offset + c.length > index);`
`43`	`43`	`if (!chunk) throw new Error('Invalid index.');`
`44`	`44`	`return chunk.get(index - chunk.offset);`
`45`	`45`	`}`
	`46`	`+`
`46`	`47`	`public set(index: number, value: T): void {`
`47`		`- const chunk = this._chunks.find((c) => c.offset < index && c.offset + c.length >= index);`
	`48`	`+ const chunk = this._chunks.find((c) => c.offset <= index && c.offset + c.length > index);`
`48`	`49`	`if (!chunk) throw new Error('Invalid index.');`
`49`	`50`	`chunk.set(index - chunk.offset, value);`
`50`	`51`	`}`