Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to pyside6 #135

Open
orki opened this issue Mar 17, 2024 · 4 comments
Open

Porting to pyside6 #135

orki opened this issue Mar 17, 2024 · 4 comments

Comments

@orki
Copy link

orki commented Mar 17, 2024

A port for pyside6 is at https://github.com/orki/lucaschessR2/tree/pyside6-porting which I have been using successfully for 2 months on Linux. It is viable for normal use, with a few bugs with the vast majority of functionality working well; the branch should work well for Windows too since nothing OS-specific has been touched, but I don't have Windows to test. It is nowhere near in shape for a PR since my branch makes no attempt whatsoever to maintain pyside2 compatibility.

I'm happy to keep it moving, but I don't think that it is worth writing a compatibility layer to provide both pyside2 and pyside6 compatibility. If you are interested in pyside6, and if you have not already started this work, how would you like to proceed with this branch?

@lukasmonk
Copy link
Owner

I have made some attempts on my own, initially with problems with the sound, and I have not spent time solving it, because the functionality is the same, unless you tell me otherwise, so I have not continued. I think what it brings is only the future, which is a lot, but there is no rush.
So sooner or later I'll have to make the jump, and your fork will probably save me work as it is.
My current roadmap is to stabilize the program on the current version, without many changes, and maybe open an R6 repository if I have a bug-free pyside6 version.

@lukasmonk
Copy link
Owner

lukasmonk commented Mar 17, 2024

There is an additional problem and pyside6 does not seem to be compatible with 32-bit versions, which are supported to windows.

@orki
Copy link
Author

orki commented Mar 17, 2024

The only sound issue I found was a minor incompatibility, which required a straightforward fix. If there are other sound-related issues, I'm not aware of them.
The reason for my port to pyside6 is that pyside2 has not been available in Fedora for a few months and likely other Linux distributions soon since Qt 5.x will no longer support any new releases of python 3. Not sure about others, but this was sufficient impetus for me to build pyside6 and make the necessary changes to LucasChess. When you plan on moving to pyside6, please let me know and I'll be happy to assist.

@ruschach
Copy link

Hi orki
please, can you update your fork to version R2.14i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants