Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed errors in earth911 mock APIs #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohit-yadavv
Copy link

@rohit-yadavv rohit-yadavv commented Sep 2, 2023

fixes #224
I have fixed errors in earth911 mock APIs
updated res.send({ err: "invalid key" })to return res.send({ err: "invalid key" });

image

@lugenx
Copy link
Owner

lugenx commented Sep 6, 2023

thank you @rohit-yadavv, this issue is being reviewed. in the future, kindly ensure you first create an issue (if one doesn't already exist) before making changes. after creating the issue, please comment on it asking for assignment. this ensures your efforts align with the project's direction and prevents any potential wasted effort.

@vishwaszadte
Copy link
Collaborator

Thank you @rohit-yadavv
Please feel free to look at any other endpoints which may have the same issue and let us know.

@lugenx
Copy link
Owner

lugenx commented Oct 23, 2023

@vishwaszadte Since we haven't received a response, could you please review and either approve or reject it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants