Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier setting in config file in the repo should apply all contributors code automatically #94

Open
lugenx opened this issue Dec 7, 2022 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@lugenx
Copy link
Owner

lugenx commented Dec 7, 2022

No description provided.

@lugenx lugenx added this to ecohabit Dec 7, 2022
@lugenx lugenx converted this from a draft issue Dec 7, 2022
@lugenx lugenx added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 7, 2022
@AbhiBajpaishek
Copy link
Contributor

If we use a pre-commit hook to format with every commit, will that work? As prettier will already we installed as a dev dependency.

@lugenx
Copy link
Owner Author

lugenx commented Dec 14, 2022

i am not familiar with pre-commit hooks, if that solves the problem it's great actually. could you take care of that?

@AbhiBajpaishek
Copy link
Contributor

I've also never implemented this myself but I want to pick this up. Could you please edit the Issue title and assign this ticket to me?

@lugenx lugenx changed the title Indicate on the "contributing.md" (how-to-contribute.md) file that this project requires "prettier" installed on the contributor's IDE. Prettier setting in config file in the repo should apply all contributors code automatically Dec 14, 2022
@lugenx
Copy link
Owner Author

lugenx commented Dec 14, 2022

edited and assigned, thank you.

@AbhiBajpaishek
Copy link
Contributor

AbhiBajpaishek commented Dec 22, 2022

Facing hurdles on this as we have mono repo kind of setup and preCommit is struggling as there are mutiple package.json and .git file is not in same folder as in package.json.

I'm still trying will keep updated.

@lugenx
Copy link
Owner Author

lugenx commented Dec 22, 2022

thank you for the update.

@lugenx lugenx moved this from Todo to In Progress in ecohabit Jan 23, 2023
@lugenx
Copy link
Owner Author

lugenx commented Mar 1, 2023

@AbhiBajpaishek, are you still working on this? I know this is a tricky issue. I also couldn't figure it out. I will remove an assignment from this to see if it can catch the attention of someone with a solution. Please still let me know if you find out.

@lugenx lugenx removed documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 1, 2023
@AyanDas348
Copy link

@lugenx Hi I have some idea on how to use pre-commit hooks to resolve this issue. Can I work on it?

@lugenx
Copy link
Owner Author

lugenx commented May 23, 2023

hi @AyanDas348 , sure, please go ahead. I have assigned this issue to you 👍

@itegika
Copy link

itegika commented Jul 28, 2023

hi @lugenx , if this issue is open, assign it to me, please. Thanks

@lugenx lugenx assigned itegika and unassigned AyanDas348 Aug 1, 2023
@lugenx
Copy link
Owner Author

lugenx commented Aug 1, 2023

sure, i assigned this to you @itegika, please make sure that you read all the comments above before starting to work. let me know if you have any questions.

@itegika
Copy link

itegika commented Aug 1, 2023

Sure, thank you)

@itegika
Copy link

itegika commented Aug 4, 2023

Hi, @lugenx , sent PR regarding this issue https://github.com/lugenx/ecohabit/pull/233
Thanks

@AyanDas348
Copy link

Hi, @lugenx found a solution using husky. Is that an option available?

@itegika itegika removed their assignment Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

4 participants