add a private route component #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Owobilum! just a friendly reminder, please comment on the issue to be assigned before working on it, so we know you are working on it and don't accidentally assign a second person I will review this PR by tomorrow latest! |
lugenx
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Hi @Owobilum, Thank you for your contribution. For future reference, please comment under the issue to get assigned before starting work.
Regarding your current PR:
- Please ensure one PR addresses only one issue. Could you revert the changes for one of the issues? We'd prefer separate PRs for each issue.
- After this PR is merged and if the other issue is still available, I can assign it to you. Please avoid having two simultaneous PRs.
Thanks for understanding and looking forward to your revised PR!
|
Hello @lugenx, feedback is noted. Will revise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?