Generate ESM/CJS variants of dynamicIconImports
#2437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #2366
What is the purpose of this pull request?
Description
When trying to bundle my library with an import of
dynamicIconImports
:I get this error:
I think there are 3 options to solve this:
"type": "module"
in thepackage.json
.mjs
as extensionI chose the second option for simplicity and now it creates two separate files for CJS and ESM. Let me know if there are concerns.
I tried to rename the file locally to
.mjs
which resolved the error.Before Submitting