From 35df0e78f8c1a31f5fcf0acd14d97f6eb4496491 Mon Sep 17 00:00:00 2001 From: Lucas Nelaupe Date: Wed, 29 Jun 2022 13:45:33 +0800 Subject: [PATCH] Update danger (#413) --- Dangerfile | 52 ++-------------------------------------------------- 1 file changed, 2 insertions(+), 50 deletions(-) diff --git a/Dangerfile b/Dangerfile index 9635559e..46a54a07 100644 --- a/Dangerfile +++ b/Dangerfile @@ -9,54 +9,6 @@ warn("PR is classed as Work in Progress") if github.pr_title.include? "WIP" # Warn when there is a big PR warn("Big PR, try to keep changes smaller if you can") if git.lines_of_code > 500 -# Added (or removed) library files need to be added (or removed) from the -# Carthage Xcode project to avoid breaking things for our Carthage users. -added_swift_library_files = !(git.added_files.grep(/Sources.*\.swift/).empty?) -deleted_swift_library_files = !(git.deleted_files.grep(/Sources.*\.swift/).empty?) -modified_carthage_xcode_project = !(git.modified_files.grep(/SwiftQueue\.xcodeproj/).empty?) -if (added_swift_library_files || deleted_swift_library_files) && !modified_carthage_xcode_project - fail("Added or removed library files require the Carthage Xcode project to be updated.") -end - -# Check for dependencies update -podspec_updated = !git.modified_files.grep(/SwiftQueue.podspec/).empty? - -cartfile_updated = !git.modified_files.grep(/Cartfile/).empty? -cartfile_resolved_updated = !git.modified_files.grep(/Cartfile.resolved/).empty? - -spm_updated = !git.modified_files.grep(/Package.swift/).empty? -spm_resolved_updated = !git.modified_files.grep(/Package.resolved/).empty? - -# Warn if Cartfile is updated but not Cartfile.resolved -if cartfile_updated && !cartfile_resolved_updated - warn("The `Cartfile` has been updated but not the `Cartfile.resolved`. Did you forgot to run `carthage update` ?") -end - -# Warn if Package.swift is updated but not Package.resolved -if spm_updated && !spm_resolved_updated - warn("The `Package.swift` has been updated but not the `Package.resolved`. Did you forgot to run `swift package update` ?") -end - -# Warn if Package.resolved and cartfile.resolved are not updated at the same time -if (cartfile_resolved_updated && !spm_resolved_updated) || (spm_resolved_updated && !cartfile_resolved_updated) - warn("The `Package.resolved` or `cartfile.resolved` was updated, but not both. Did you forgot to run `carthage update` or `swift package update`?") -end - -# Warn if podpec has been update but not Cartfile or Package.swift -if podspec_updated && (!cartfile_updated || !spm_updated) - warn("The `podspec` was updated, but there were no changes in either the `Cartfile` nor `Package.swift`. Did you forget updating `Cartfile` or `Package.swift`?") -end - -# Warn if cartfile has been update but not podspec or Package.swift -if cartfile_updated && (!podspec_updated || !spm_updated) - warn("The `Cartfile` was updated, but there were no changes in either the `podspec` nor `Package.swift`. Did you forget updating `podspec` or `Package.swift`?") -end - -# Warn if Package.swift has been update but not podspec or Cartfile -if spm_updated && (!podspec_updated || !cartfile_updated) - warn("The `Package.swift` was updated, but there were no changes in either the `podspec` nor `Cartfile`. Did you forget updating `podspec` or `Cartfile`?") -end - # Warn when library files has been updated but not tests. tests_updated = !git.modified_files.grep(/Tests/).empty? if has_app_changes && !tests_updated @@ -68,5 +20,5 @@ swiftlint.lint_files # Run prose prose.ignored_words = ["SPM", "CFBundleVersion", "JobInfo", "compactMap", "lastError", "args", "enum", "SwiftQueue", "JobBuilder", "SwiftQueueManager", "onError", "carthage", "Rechability", "Cleanup", "TimeInterval", "SingleInstance", "Swiftlint", "travis", "params", "JobCompletion", "inSecond", "onRetry", "onRemove", "UniqueUUID", "OperationQueue", "SwiftQueueJob", "uuid", "DEPS", "serializer", "deserialization", "Deserialize"] -# prose.ignore_numbers = true -# prose.check_spelling +prose.ignore_numbers = true +prose.check_spelling