Skip to content

Commit 04b3493

Browse files
author
lucas-nelson-uiuc
committed
dev: make alias final conversion
1 parent 26e123e commit 04b3493

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/tidy_tools/model/convert.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def convert_field(cls_field: attrs.Attribute, cls_field_exists: bool) -> Column:
2626
"""
2727
if not cls_field.default:
2828
if not cls_field_exists:
29-
column = F.lit(None).alias(cls_field.alias)
29+
column = F.lit(None)
3030
else:
3131
column = F.col(cls_field.alias)
3232

@@ -39,7 +39,7 @@ def convert_field(cls_field: attrs.Attribute, cls_field_exists: bool) -> Column:
3939
assert return_type is Column, "Factory must return a pyspark.sql.Column!"
4040
column = cls_field.default.factory()
4141
elif not cls_field_exists:
42-
column = F.lit(cls_field.default).alias(cls_field.alias)
42+
column = F.lit(cls_field.default)
4343
else:
4444
column = F.when(
4545
F.col(cls_field.alias).isNull(), cls_field.default
@@ -74,4 +74,4 @@ def convert_field(cls_field: attrs.Attribute, cls_field_exists: bool) -> Column:
7474
if cls_field.converter:
7575
column = cls_field.converter(column)
7676

77-
return column
77+
return column.alias(cls_field.alias)

0 commit comments

Comments
 (0)