lib.join is slow and unnecessary

[dlaurie]

The algorithm in lib.join is extremely slow, requiring allocation of a new string for every element in the array. Moreover, lib.join appears to do exactly the same as the standard function table.concat.

Suggestion: replace its definition by

lib.join = table.concat

[dlaurie]

Never mind. I can monkey-patch that later, after I require 'xml'.

lib.join does not always do exactly the same: it respects the __concat metamethod but table.concat does not.

[gaspard]

Hi @dlaurie. I'm sorry that I don't work with Lua anymore and am not maintaining this. I can give you write access to the repo and arrange so that you can publish to luarocks if you want.

[dlaurie]

Hi Gaspard, Thank you for responding. I would be grateful for write access, which I promise to use responsibly. Best wishes. Dirk 2018-07-14 13:42 GMT+02:00 Gaspard Bucher <[email protected]>:

…

Hi @dlaurie <https://github.com/dlaurie>. I'm sorry that I don't work with Lua anymore and am not maintaining this. I can give you write access to the repo and arrange so that you can publish to luarocks if you want. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9TPKe7DlQsUBWsNmKt5a3Vrp8ZF2S3ks5uGdksgaJpZM4VEiJ2> .

[lubyk]

OK. Done. Don't hesitate to ring me if you need access to other packages.

[gaspard]

(I mean ring @gaspard).