Fix memory leak in HTTPResourcePath

Fixed an issue where query parameters or fragments in an HTTP URL would cause it to be considered as having a different root URI.  This caused a new HTTP session to be created and cached each time an HTTP URL with a different query parameter was accessed.

This resulted in a memory leak in datalinker when it was using HTTPResourcePath to access S3 presigned URLs, which always have unique query parameters.

Author: dhirving

doc/changes/DM-43739.bugfix.md

@@ -0,0 +1 @@
+`ResourePath.root_uri()` now strips query parameters and fragments from the URL.  This fixes a memory leak where `HttpResourcePath` would create and cache a new HTTP session for each different set of query parameters.

python/lsst/resources/_resourcePath.py

@@ -417,7 +417,7 @@ def root_uri(self) -> ResourcePath:
         uri : `ResourcePath`
             Root URI.
         """
-        return self.replace(path="", forceDirectory=True)
+        return self.replace(path="", query="", fragment="", params="", forceDirectory=True)
 
     def split(self) -> tuple[ResourcePath, str]:
         """Split URI into head and tail.

tests/test_http.py

@@ -59,6 +59,29 @@ class GenericHttpTestCase(GenericTestCase, unittest.TestCase):
     scheme = "http"
     netloc = "server.example"
 
+    def test_root_uri(self):
+        self.assertEqual(ResourcePath("http://server.com").root_uri(), ResourcePath("http://server.com/"))
+        self.assertEqual(
+            ResourcePath("http://user:[email protected]:3000/").root_uri(),
+            ResourcePath("http://user:[email protected]:3000/"),
+        )
+        self.assertEqual(
+            ResourcePath("http://user:[email protected]:3000/some/path").root_uri(),
+            ResourcePath("http://user:[email protected]:3000/"),
+        )
+        self.assertEqual(
+            ResourcePath("http://user:[email protected]:3000/some/path#fragment").root_uri(),
+            ResourcePath("http://user:[email protected]:3000/"),
+        )
+        self.assertEqual(
+            ResourcePath("http://user:[email protected]:3000/some/path?param=value").root_uri(),
+            ResourcePath("http://user:[email protected]:3000/"),
+        )
+        self.assertEqual(
+            ResourcePath("http://user:[email protected]:3000/some/path;parameters").root_uri(),
+            ResourcePath("http://user:[email protected]:3000/"),
+        )
+
 
 class HttpReadWriteWebdavTestCase(GenericReadWriteTestCase, unittest.TestCase):
     """Test with a real webDAV server, as opposed to mocking responses."""