Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the return URL for login to include router parameters #92

Open
jonathansick opened this issue Aug 18, 2022 · 0 comments
Open

Set the return URL for login to include router parameters #92

jonathansick opened this issue Aug 18, 2022 · 0 comments
Assignees
@jonathansick
Labels
bug Something isn't working

Comments

@jonathansick
Copy link
Member

Right now when logging in from a page with path parameters, the page doesn't include values for the path parameters. For example, a return URL for a Times Square PR preview page is /times-square/github-pr/[owner]/[repo]/[commit/[...path]. The login component needs to use the actual page URL rather than the next route path.
@jonathansick jonathansick added the bug Something isn't working label Aug 18, 2022
@jonathansick jonathansick self-assigned this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathansick jonathansick

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathansick