Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable quotes (no support for: --quoting-style, QUOTING_STYLE, or --literal) #894

Closed
1 task done
globau opened this issue Sep 3, 2023 · 3 comments · Fixed by #900
Closed
1 task done
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature request

Comments

@globau
Copy link

globau commented Sep 3, 2023

Version

  • latest

version

lsd 1.0.0

What OS are you seeing the problem on?

macOS

installation

homebrew

term

xterm-256color

ls-colors

di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43

What happened?

`error: unexpected argument '--literal' found`

What expected?

`lsd` should honour `lsd --literal`, `lsd --quoting-style=literal`, and/or `QUOTING_STYLE=literal lsd`

What else?

Sadly #746 added quotes around filenames without any way to opt out.

See https://www.gnu.org/software/coreutils/quotes.html for the various options that GNU's `ls` provides.

Adding just `literal` initially would be valuable to those who are not in favour of this somewhat controversial change.
@zwpaper
Copy link
Member

zwpaper commented Sep 3, 2023

thanks for the advice!
/kind feature
/good-first-issue
/help

@muniu-bot
Copy link

muniu-bot bot commented Sep 3, 2023

@zwpaper:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

thanks for the advice!
/kind feature
/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muniu-bot muniu-bot bot added kind/feature New feature request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 3, 2023
@PanGan21
Copy link
Contributor

Hi! I am not sure if someone is working on this but I did some effort implementing it in #900
Please let me know if something more is required :)

zwpaper pushed a commit that referenced this issue Sep 19, 2023
Add support for `--literal` in order to opt out showing filenames with
quotes
Closes: #894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants