Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine ConversationAddMembersScreen and CreatePersonalConversationScreen #376

Open
julian-wls opened this issue Feb 3, 2025 · 0 comments
Open

Combine ConversationAddMembersScreen and CreatePersonalConversationScreen #376

julian-wls opened this issue Feb 3, 2025 · 0 comments
Assignees
@julian-wls
Labels
chore House keeping; non-functional, non-visual changes

Comments

@julian-wls
Copy link
Contributor

Problem Description

Currently, there are two very similar composable functions ConversationAddMembersScreen and CreatePersonalConversationScreen, which both allow users to add other users to a conversation.

Suggested changes

Both functions should be combined into one by extracting their common logic.
@julian-wls julian-wls added the chore House keeping; non-functional, non-visual changes label Feb 3, 2025
@julian-wls julian-wls self-assigned this Feb 3, 2025
@julian-wls julian-wls mentioned this issue Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julian-wls julian-wls

Labels
chore House keeping; non-functional, non-visual changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julian-wls