Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG embedding is broken #304

Open
eduardomozart opened this issue Jun 21, 2023 · 0 comments
Open

SVG embedding is broken #304

eduardomozart opened this issue Jun 21, 2023 · 0 comments

Comments

@eduardomozart
Copy link
Contributor

eduardomozart commented Jun 21, 2023 •
edited
Loading

As cited on #296, the SVG embedding function is still broken.

When using the following fork from PlantUML Parser: https://github.com/eduardomozart/dokuwiki_plantumlparser/tree/56a82f450a611338d8771e888a1d9774306e7219

I intentionally commented the line $renderer->_addStringAsSVGImage because embedding a SVG image on an ODT file using it simply fails.

There's other plugins that relies on this method to embed SVG images on ODT files, as dokuwiki-plugin-switchpanel, as can be seen in https://github.com/GreenItSolutions/dokuwiki-plugin-switchpanel/blob/561d049aef21afb3d54406d1b62373e8275ce766/syntax.php#L467

I attempted to create a fix at #293 but the function is now being called as it should but it didn't seem to fix the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eduardomozart