Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with False Positive Identification #2

Closed
crg-n opened this issue Apr 6, 2021 · 3 comments · Fixed by #4
Closed

Bug with False Positive Identification #2

crg-n opened this issue Apr 6, 2021 · 3 comments · Fixed by #4
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@crg-n
Copy link

crg-n commented Apr 6, 2021

Hi, first thanks for the great tool. Seems to be designed to do exactly what I'm looking to do!

However, I think there is some sort of odd bug with the False Positive detection. I attach an example excerpt of some segmentations:

As you can see the initial segmentation has some small spotty detections in the top right that aren't in the ground truth. This seems to show up in the segmentation metrics with n_true_labels 32 and n_pred_labels 40, however n_false_positives is only 2. Running area_opening to remove these as shown below and then re-running umetrics correctly reduces the number of predicted labels bringing it closer to the number of true labels but the false positives don't change and nor does the Jaccard index. I am correctly passing the ground to umetrics.calculate first and then the prediction second. Interestingly swapping them around seems to make things work as expected but they are incorrectly called false negatives etc.

Any idea what's going on here?

Many thanks,
Craig

@quantumjot
Copy link
Collaborator

Hi @crgnclsn - thanks for this report. Seems like we should really add some tests ;) Do you want to help?

@quantumjot quantumjot added the bug Something isn't working label Apr 13, 2021
@SabraHashemi
Copy link

is this bug solved?
could you explain when this happen totally?

@quantumjot quantumjot added the help wanted Extra attention is needed label Sep 1, 2021
@quantumjot quantumjot linked a pull request Nov 16, 2023 that will close this issue
9 tasks
@quantumjot quantumjot mentioned this issue Nov 20, 2023
9 tasks
@quantumjot
Copy link
Collaborator

I think this bug should be fixed now. LMK if you end up trying it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants