Skip to content

Commit 85fbebe

Browse files
committed
[pattgen,dv] Tidy up testplan for cnt_rollover
The text was a bit hard to understand. Fix that, and also give a "pattgen_" prefix to the name of the test, matching the style of other tests. Signed-off-by: Rupert Swarbrick <[email protected]>
1 parent c88cd6f commit 85fbebe

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

hw/ip/pattgen/data/pattgen_testplan.hjson

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,25 +55,30 @@
5555
{
5656
name: cnt_rollover
5757
desc: '''
58-
Checking ip operation with random counter values
58+
Check that the IP works correctly with a range of counter values.
5959

6060
Stimulus:
61-
- Program the pre-divider and size registers to unconstraint random values
62-
- Program the clk_cnt, bit_cnt and rep_cnt to values less than but close to
63-
predivider and size registers, so that counting would take a reasonable
64-
number of clock cycles
65-
- include programming for corner cases
66-
repeat programming a random number of times
67-
- Start and stop channels quickly
68-
- Clear interrupts quickly
61+
62+
When picking a random configuration for a channel, this testpoint wants to see a large
63+
range of values for prediv (cycles per bit), len (number of bits in the message) and
64+
reps (number of pattern repetitions).
65+
66+
To avoid the test taking a very long time, the product of the three values can be
67+
constrained with a bound.
68+
69+
To check for edge cases, the random values described above should be weighted to
70+
sample the corners more often.
6971

7072
Checking:
71-
- Include functional cover point that rollover value is reached and counter is re-enabled:
72-
- Ensure patterns are correctly generated
73-
- Ensure interrupts are robust asserted and cleared (e.g. at the high data rate)
73+
74+
- Use the standard monitor/scoreboard to check that the generated patterns are as
75+
expected.
76+
77+
- Add a functional cover point requiring that the rollover value is reached and then
78+
the counter is re-enabled.
7479
'''
7580
stage: V2
76-
tests: ["cnt_rollover"]
81+
tests: ["pattgen_cnt_rollover"]
7782
}
7883
{
7984
name: error

hw/ip/pattgen/dv/pattgen_sim_cfg.hjson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
}
6969

7070
{
71-
name: cnt_rollover
71+
name: pattgen_cnt_rollover
7272
uvm_test_seq: pattgen_cnt_rollover_vseq
7373
}
7474

0 commit comments

Comments
 (0)