Skip to content

Commit 10c1eb7

Browse files
committed
[ci] Allow + in Bazel target names
This has come up a couple of times recently with names containing `C++` which are allowed by Bazel but banned by this rule. I don't think a `+` could cause the kind of type confusion that the comment here talks about. Also Bazel 8 uses `+` in canonical target names so we may need to accept them anyway if `query` ever spits out one of those. Signed-off-by: James Wainwright <[email protected]>
1 parent 904bd36 commit 10c1eb7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ci/scripts/lib/bazel_query.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def find_targets_with_banned_chars(self) -> Iterable[Tuple[str, Set[str]]]:
5757
set of characters that must be removed from the target's name.
5858
5959
"""
60-
allowed_chars = set(string.ascii_letters + string.digits + '/:_-.')
60+
allowed_chars = set(string.ascii_letters + string.digits + '/:_-.+')
6161
for target in self.query("//..."):
6262
if bad_chars := set(target) - allowed_chars:
6363
yield (target, bad_chars)

0 commit comments

Comments
 (0)