Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to set the width of the board? #118

Open
droundy opened this issue Aug 20, 2020 · 5 comments · May be fixed by #137
Open

Configuration to set the width of the board? #118

droundy opened this issue Aug 20, 2020 · 5 comments · May be fixed by #137

Comments

@droundy
Copy link
Contributor

droundy commented Aug 20, 2020

It would be lovely to have a configuration to set the width of the board, and just have that fixed. That would force users to only scroll down, which I think would make it harder to simply fail to notice that something was written off-screen.

@lovasoa
Copy link
Owner

lovasoa commented Aug 21, 2020

Hello @droundy ! Would you be interested in implementing that feature ?

@droundy
Copy link
Contributor Author

droundy commented Aug 21, 2020

I would be potentially, but would definitely need guidance. I've been hacking a bit and having trouble understanding enough of the design to make my changes.

@shabashev-ivan
Copy link

Hi I was doing a function like this, just split the max board size into two variables and replace them in the server validation code and the zoom on the client (maybe somewhere else, but I forgot), then do Tools.scale = document.body.clientWidth / Tools. server_config.MAX_BOARD_SIZE_X; on page load. If @lovasoa is interested in using a function like this I can do it

@droundy
Copy link
Contributor Author

droundy commented Aug 25, 2020

That sounds lovely. If you submit a pull request I could use it as a starting point even if @lovasoa wanted a different interface.

droundy added a commit to droundy/whitebophir that referenced this issue Sep 24, 2020
@DanielHabenicht
Copy link
Contributor

@lovasoa Should I open a new Issue for keeping the board size infinite but zooming the content into view on first connection?
This would mean that the whole content of the board is visible, independent of the screen size of the device connected.
The user could zoom in afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants